fix(flagd): Add support for FLAGD_SYNC_PORT#626
Open
kylejuliandev wants to merge 4 commits intoopen-feature:mainfrom
Open
fix(flagd): Add support for FLAGD_SYNC_PORT#626kylejuliandev wants to merge 4 commits intoopen-feature:mainfrom
kylejuliandev wants to merge 4 commits intoopen-feature:mainfrom
Conversation
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for the FLAGD_SYNC_PORT environment variable, specifically for the in-process resolver. The configuration logic in FlagdConfig has been updated to prioritize this variable when applicable, and the README has been updated to reflect these changes. Additionally, unit and E2E tests were added or updated to cover the new functionality. Feedback focuses on correcting typos in the source code and documentation, and improving the robustness of the new unit tests by ensuring proper environment variable cleanup.
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
askpt
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Adds support for the
FLAGD_SYNC_PORTenvironment variable when configuring the the Flagd Provider. When not set we will fallback to theFLAGD_PORT. I have enabled the@legacy-sync-porte2e tests and added some unit tests to reinforce this backwards compatibility.Related Issues
Fixes #478
Parent issue: open-feature/flagd#1573
Notes
Follow-up Tasks
How to test