feat(ofrep): AOT compatibility by aldy505 · Pull Request #651 · open-feature/dotnet-sdk-contrib

aldy505 · 2026-05-18T07:32:48Z

This PR

Provide AOT-compatible path for OFREP, maintains backward compatibility for users with dynamic code

Related Issues

Closes #600

Notes

Follow-up Tasks

How to test

gemini-code-assist

Code Review

This pull request introduces Native AOT support for the OFREP provider by implementing typed evaluation methods and transitioning to source-generated JSON serialization. It also adds a dedicated AOT compatibility test project. Feedback focuses on resolving potential compilation errors related to dictionary type mismatches with the OpenFeature SDK and the use of .NET 5+ specific HttpContent methods in multi-targeted code. Additionally, there are recommendations to refactor duplicated validation and response mapping logic to improve maintainability.

askpt · 2026-05-18T20:47:08Z

@aldy505 Could you please sign-off your commits? You can follow these instructions:

Ensure you have a local copy of your branch by checking out the pull request locally via command line.
In your local branch, run: git rebase HEAD~4 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin feat/aot-compatibility

Closes open-feature#600 Provide AOT-compatible path for OFREP, maintains backward compatibility for users with dynamic code Signed-off-by: Reinaldy Rafli <github@reinaldyrafli.com>

Signed-off-by: Reinaldy Rafli <github@reinaldyrafli.com>

…standard compatibility Signed-off-by: Reinaldy Rafli <github@reinaldyrafli.com>

askpt

I saw that you have a lot of "backward compatibility" in the OfrepClient. This client is not supposed to be used by the external consumers. I would encourage to remove the backwards compatibility and use only the AOT path.

askpt · 2026-05-19T15:18:00Z

+      - name: OFREP AOT compatibility check
+        if: matrix.os == 'ubuntu-latest'
+        run: dotnet publish test/OpenFeature.Providers.Ofrep.AotCompatibility/OpenFeature.Providers.Ofrep.AotCompatibility.csproj -c Release -r linux-x64 --self-contained true -p:TreatWarningsAsErrors=true


Have a look at: https://github.com/open-feature/dotnet-sdk/blob/main/.github/workflows/aot-compatibility.yml

We would prefer to have compatibility checks to all releases and machine types.

This is done, though I'm not confident on enabling it for any other provider than Ofrep.

askpt · 2026-05-19T15:19:10Z

Can you consider moving this file to a single file app?

I don't have much experience on this. I thought you meant .csx file, then I found this post: https://learn.microsoft.com/en-us/dotnet/core/sdk/file-based-apps

Might take a while for this.

Signed-off-by: Reinaldy Rafli <github@reinaldyrafli.com>

aldy505 · 2026-05-29T02:00:42Z

@askpt Applied everything other than moving to single file app.

askpt

Added a couple of comments. Thanks for making the changes.

The single file can wait.

askpt · 2026-06-05T16:31:36Z

        EvaluationContext? context, CancellationToken cancellationToken = default)
    {
-#if NET8_0_OR_GREATER
+        #if NET8_0_OR_GREATER


Suggested change

#if NET8_0_OR_GREATER

#if NET8_0_OR_GREATER

askpt · 2026-06-05T16:33:02Z


-        var response = await this._client.EvaluateFlag(flagKey, defaultValue,
-            context, cancellationToken).ConfigureAwait(false);
+        var response = await evaluate(flagKey, defaultValue, context, cancellationToken).ConfigureAwait(false);


Why are you passing a function here instead of calling directly the method?

askpt · 2026-06-05T16:33:21Z

+    /// <remarks>
+    /// This generic method is provided for backward compatibility.
+    /// For Native AOT scenarios, use the typed methods (EvaluateBooleanFlag, EvaluateStringFlag, etc.) instead.
+    /// </remarks>


Is this still valid?

askpt · 2026-06-05T16:34:23Z

+    /// <summary>
+    /// Evaluates a flag value using the OFREP API. This generic method is provided for backward compatibility.
+    /// For Native AOT scenarios, use the typed methods (EvaluateBooleanFlag, EvaluateStringFlag, etc.) instead.
+    /// </summary>
+    /// <typeparam name="T">The type of the flag value.</typeparam>
+    /// <param name="flagKey">The key of the flag to evaluate.</param>
+    /// <param name="defaultValue">The default value to return if evaluation fails.</param>
+    /// <param name="context">The evaluation context.</param>
+    /// <param name="cancellationToken">A token to cancel the operation.</param>
+    /// <returns>The evaluated flag response.</returns>
+    /// <remarks>
+    /// This method delegates to the AOT-safe typed implementation for OFREP-supported value types.
+    /// Other generic types use the legacy reflection-based JSON path and are not AOT-safe.
+    /// </remarks>


This seems to be now fully native AOT compliant. This needs to be removed.

aldy505 requested review from a team as code owners May 18, 2026 07:32

github-actions Bot assigned askpt and weyert May 18, 2026

github-actions Bot requested review from askpt and weyert May 18, 2026 07:33

gemini-code-assist Bot reviewed May 18, 2026

View reviewed changes

aldy505 added 4 commits May 19, 2026 14:52

feat(ofrep): AOT compatibility

7b1a7de

Closes open-feature#600 Provide AOT-compatible path for OFREP, maintains backward compatibility for users with dynamic code Signed-off-by: Reinaldy Rafli <github@reinaldyrafli.com>

fix(ofrep): missing 'IsAotCompatible' on the csproj

1799c3b

Signed-off-by: Reinaldy Rafli <github@reinaldyrafli.com>

fix(ofrep): rollback to IDictionary<string, object>

0cb441d

Signed-off-by: Reinaldy Rafli <github@reinaldyrafli.com>

fix(ofrep): call ReadAsStreamAsync without cancellation token for net…

f7f84de

…standard compatibility Signed-off-by: Reinaldy Rafli <github@reinaldyrafli.com>

aldy505 force-pushed the feat/aot-compatibility branch from 74a698c to f7f84de Compare May 19, 2026 07:52

askpt reviewed May 19, 2026

View reviewed changes

feat(ci): run AOT compatibility check for ofrep provider

4019d56

Signed-off-by: Reinaldy Rafli <github@reinaldyrafli.com>

aldy505 force-pushed the feat/aot-compatibility branch from 05fd71d to 4019d56 Compare May 29, 2026 01:35

aldy505 added 2 commits May 29, 2026 08:48

feat: use native AOT code path

1edbd43

Signed-off-by: Reinaldy Rafli <github@reinaldyrafli.com>

fix(test): remove old method names

8b60b1b

Signed-off-by: Reinaldy Rafli <github@reinaldyrafli.com>

askpt reviewed Jun 5, 2026

View reviewed changes

Conversation

aldy505 commented May 18, 2026

This PR

Related Issues

Notes

Follow-up Tasks

How to test

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

askpt commented May 18, 2026

Uh oh!

askpt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aldy505 commented May 29, 2026

Uh oh!

askpt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants