-
Notifications
You must be signed in to change notification settings - Fork 20
feat: Move OTEL hooks to the SDK #338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #338 +/- ##
==========================================
+ Coverage 86.47% 86.90% +0.43%
==========================================
Files 42 44 +2
Lines 1671 1749 +78
Branches 177 184 +7
==========================================
+ Hits 1445 1520 +75
Misses 187 187
- Partials 39 42 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
# Conflicts: # Directory.Packages.props
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
Thanks for starting this PR but I think we should wait until this spec PR is merged before moving this hook to the SDK. |
Signed-off-by: André Silva <[email protected]>
namespace OpenFeature.Hooks; | ||
|
||
/// <summary> | ||
/// Stub. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doc doesn't appear correct.
c95eefa
to
47cd3f4
Compare
47cd3f4
to
7b6ef96
Compare
Signed-off-by: André Silva <[email protected]>
…pdate OpenTelemetry version Signed-off-by: André Silva <[email protected]>
Move OTEL hooks to the SDK
This pull request moves the OTEL hooks to the SDK, as discussed in the linked issue (#175). I also changed the unit tests to clean up some code. Finally, I moved the documentation.
Related Issues
Fixes #175
Notes
Implementation of Tracing and Metrics Hooks:
src/OpenFeature/Hooks/MetricsConstants.cs
: Introduced constants for metric names, descriptions, and attributes used in metrics collection.src/OpenFeature/Hooks/MetricsHook.cs
: Implemented theMetricsHook
class to capture metrics related to flag evaluations, including active counts, requests, successes, and errors.src/OpenFeature/Hooks/TracingConstants.cs
: Added constants for tracing attributes and event names.src/OpenFeature/Hooks/TracingHook.cs
: Implemented theTracingHook
class to capture tracing information for flag evaluations, including key, variant, provider name, and exceptions.Follow-up Tasks