Merged
Conversation
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #338 +/- ##
==========================================
+ Coverage 87.02% 87.23% +0.21%
==========================================
Files 45 47 +2
Lines 1757 1794 +37
Branches 184 182 -2
==========================================
+ Hits 1529 1565 +36
- Misses 188 190 +2
+ Partials 40 39 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
# Conflicts: # Directory.Packages.props
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Member
|
Thanks for starting this PR but I think we should wait until this spec PR is merged before moving this hook to the SDK. |
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
kinyoklion
reviewed
Jan 31, 2025
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
c95eefa to
47cd3f4
Compare
This was referenced Jan 21, 2026
Bump the nuget-production-dependencies group with 17 updates
PraveenKumarDova/opentelemetry-demo#113
Closed
This was referenced Feb 4, 2026
Closed
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move OTEL hooks to the SDK
This pull request introduces telemetry enhancements to the OpenFeature .NET SDK by adding new hooks for tracing and metrics, updating dependencies, and providing examples and tests. The most significant changes include the addition of the
TraceEnricherHookandMetricsHookclasses, integration of OpenTelemetry in the ASP.NET Core sample, and updates to dependencies to support telemetry features.Telemetry Enhancements
TraceEnricherHookto enrich telemetry traces with feature flag evaluation details, including tags and events for tracing purposes. This hook integrates with the currentActivityand supports error handling.MetricsHookfor capturing metrics such as evaluation requests, successes, errors, and active evaluations. Metrics are collected using OpenTelemetry'sMeterAPI. [1] [2]Dependency Updates
OpenTelemetry.Extensions.Hosting,OpenTelemetry.Instrumentation.AspNetCore, andOpenTelemetry.Exporter.OpenTelemetryProtocolto the ASP.NET Core sample project to support telemetry features. [1] [2]System.Diagnostics.DiagnosticSourcein the main project and centralized dependency management. [1] [2]Documentation and Examples
TraceEnricherHookandMetricsHook, including detailed descriptions, examples, and usage instructions for integrating these hooks with OpenTelemetry.TraceEnricherHookandMetricsHookwith OpenTelemetry tracing and metrics. [1] [2]Testing
MetricsHookto verify metrics collection during different stages of feature flag evaluation (e.g.,BeforeAsync,AfterAsync,ErrorAsync,FinallyAsync).Related Issues
Fixes #175
Notes
samplesapplication. This allow us to see the metrics and traces in any OTEL tool.Check the screenshots below:
Follow-up Tasks