Skip to content

chore: remove stale stash directory and unused type dependencies#28

Merged
jonathannorris merged 1 commit intomainfrom
chore/cleanup-stale-code
Apr 1, 2026
Merged

chore: remove stale stash directory and unused type dependencies#28
jonathannorris merged 1 commit intomainfrom
chore/cleanup-stale-code

Conversation

@jonathannorris
Copy link
Copy Markdown
Member

Summary

  • Removes packages/js-ofrep-worker/src/stash/ directory containing dead code from the pre-flagd-core custom implementation (workers-storage.ts, json-logic-js.d.ts)
  • Removes unused root devDependencies: @types/imurmurhash, @types/object-hash, @types/semver

These were leftovers from before the migration to @openfeature/flagd-core@^2.0.0. Nothing in the active source tree imports from stash.

Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the custom Workers-compatible storage and evaluation implementation, along with its associated type declarations and several type dependencies including @types/imurmurhash, @types/object-hash, and @types/semver. The version of @openfeature/flagd-ofrep-cf-worker is also bumped to 0.0.2. I have no feedback to provide.

@jonathannorris jonathannorris merged commit 68b884a into main Apr 1, 2026
7 checks passed
@jonathannorris jonathannorris deleted the chore/cleanup-stale-code branch April 1, 2026 19:46
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes dead “stash” implementation code from js-ofrep-worker and drops unused root @types/* devDependencies left over from pre-@openfeature/flagd-core@2 work.

Changes:

  • Deleted packages/js-ofrep-worker/src/stash/ (dead code + local type shim).
  • Removed unused root devDependencies: @types/imurmurhash, @types/object-hash, @types/semver.
  • Updated package-lock.json to reflect dependency graph changes after removals (also includes additional lockfile reshaping/upgrades).

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

File Description
packages/js-ofrep-worker/src/stash/workers-storage.ts Deleted unused Workers-specific storage/evaluation implementation.
packages/js-ofrep-worker/src/stash/json-logic-js.d.ts Deleted local TS declaration shim for json-logic-js (no longer needed if unused).
package.json Removed unused root @types/* devDependencies.
package-lock.json Removed corresponding lock entries; also includes broader lockfile changes (incl. Vite version change).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants