chore: remove stale stash directory and unused type dependencies#28
chore: remove stale stash directory and unused type dependencies#28jonathannorris merged 1 commit intomainfrom
Conversation
Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
2146681 to
f77be4a
Compare
There was a problem hiding this comment.
Code Review
This pull request removes the custom Workers-compatible storage and evaluation implementation, along with its associated type declarations and several type dependencies including @types/imurmurhash, @types/object-hash, and @types/semver. The version of @openfeature/flagd-ofrep-cf-worker is also bumped to 0.0.2. I have no feedback to provide.
There was a problem hiding this comment.
Pull request overview
Removes dead “stash” implementation code from js-ofrep-worker and drops unused root @types/* devDependencies left over from pre-@openfeature/flagd-core@2 work.
Changes:
- Deleted
packages/js-ofrep-worker/src/stash/(dead code + local type shim). - Removed unused root devDependencies:
@types/imurmurhash,@types/object-hash,@types/semver. - Updated
package-lock.jsonto reflect dependency graph changes after removals (also includes additional lockfile reshaping/upgrades).
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/js-ofrep-worker/src/stash/workers-storage.ts | Deleted unused Workers-specific storage/evaluation implementation. |
| packages/js-ofrep-worker/src/stash/json-logic-js.d.ts | Deleted local TS declaration shim for json-logic-js (no longer needed if unused). |
| package.json | Removed unused root @types/* devDependencies. |
| package-lock.json | Removed corresponding lock entries; also includes broader lockfile changes (incl. Vite version change). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
packages/js-ofrep-worker/src/stash/directory containing dead code from the pre-flagd-core custom implementation (workers-storage.ts,json-logic-js.d.ts)@types/imurmurhash,@types/object-hash,@types/semverThese were leftovers from before the migration to
@openfeature/flagd-core@^2.0.0. Nothing in the active source tree imports from stash.