chore: resolve open dependabot security alerts#217
Open
jonathannorris wants to merge 2 commits into
Open
Conversation
- fast-json-patch <3.1.1 -> ^3.1.1 via npm overrides scoped to ajv-cli (high, alert #1) Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
There was a problem hiding this comment.
Code Review
This pull request adds an override in package.json to force ajv-cli to use fast-json-patch version ^3.1.1, with corresponding updates in package-lock.json. Feedback was provided to run npm install to ensure the overrides metadata is correctly mirrored in the root of package-lock.json to prevent the lockfile from being out of sync.
Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ajv-cli@5.0.0with@jirutka/ajv-cli@^6.0.0, a maintained fork that declaresfast-json-patch: ^3.1.1natively. This resolves the prototype pollution vulnerability (alert Add flag definition #1, high severity) without anyoverridesentry.package-lock.json;npm auditreports zero vulnerabilities.-o /dev/nullto theajv compileinvocations in the Makefile. In@jirutka/ajv-cli@6, runningajv compilewithout-odumps the full compiled JS validator module to stdout (an intentional breaking change from v5, where that output was silently discarded). Since this target only validates schemas and never captures compiled output,-o /dev/nullrestores the original behavior: just theschema X is validstatus lines.Notes
ajv-clihas had no release since v5.0.0 in March 2021. The upstream fix PR (ajv-validator/ajv-cli#227) has been open for 3+ years with no maintainer response.@jirutka/ajv-cliis a maintained fork published on npm under the sameajvbinary name; thecompile -s/-rinterface used in this repo is unchanged.