chore: remove deprecated fractionalEvaluation operator#1703
chore: remove deprecated fractionalEvaluation operator#1703NeaguGeorgiana23 wants to merge 1 commit into
Conversation
✅ Deploy Preview for polite-licorice-3db33c canceled.
|
There was a problem hiding this comment.
Summary of Changes
Hello @NeaguGeorgiana23, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've refactored the flag storage layer to utilize go-memdb, an in-memory database from Hashicorp. This change is foundational, enabling future enhancements like support for duplicate flag keys, robust flag selectors with watchers, and customizable indexing, without introducing any behavioral or breaking changes. Performance benchmarks indicate no significant impact.
Highlights
- Storage Layer Refactor: The core flag storage mechanism has been re-implemented to use go-memdb, an in-memory database, laying the groundwork for advanced flag management features.
- store Package Evolution: The store package's State has been transformed into a Store object with methods wrapping the internal database, moving beyond a simple struct to a more robust data management entity.
- File and Type Renaming: For consistency and clarity, flags.go was renamed to store.go, and the State type within the store package was renamed to Store.
- Flag Indexing Enhancement: A new, non-serialized Key field has been added to the flag type, specifically for internal indexing purposes to improve data retrieval.
- Constructor Update: A new constructor for the Store has been introduced, accepting a logger and returning an error, with the old constructor deprecated to maintain backward compatibility for consumers.
- Deprecated Feature Removal: The LegacyFractionEvaluationName operator and its associated legacy_fractional.go and legacy_fractional_test.go files have been removed, as this evaluation type was deprecated.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request removes the deprecated legacy fractional evaluation feature. This is a good cleanup of the codebase, and the changes are correctly implemented by removing the feature's source, test files, and its registration. The PR description also mentions a larger refactoring to use go-memdb for flag storage. This architectural change is well-reasoned and sets a good foundation for future development.
Signed-off-by: Neagu Georgiana <neagugeorgiana247@gmail.com >
This PR
removes 'fractionalEvaluation' operator because it has been replaced with fractional