chore!: removes the `fractionalEvaluation` operator since it has been replaced with `fractional`. by NeaguGeorgiana23 · Pull Request #1704 · open-feature/flagd

NeaguGeorgiana23 · 2025-08-05T15:05:57Z

This PR

adds this new feature

Related Issues

removes the fractionalEvaluation operator since it has been replaced with fractional.

netlify · 2025-08-05T15:06:03Z

✅ Deploy Preview for polite-licorice-3db33c canceled.

Name	Link
🔨 Latest commit	`7044e28`
🔍 Latest deploy log	https://app.netlify.com/projects/polite-licorice-3db33c/deploys/68934b8a930f5f000854b409

gemini-code-assist

Summary of Changes

Hello @NeaguGeorgiana23, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I am removing the deprecated fractionalEvaluation operator and its associated implementation and tests. This operator has been superseded by the fractional operator, and its removal streamlines the codebase by eliminating obsolete components.

Highlights

Operator Deregistration: The fractionalEvaluation operator has been removed from the jsonlogic resolver in core/pkg/evaluator/json.go, ensuring it can no longer be registered or used.
Deprecated Code Removal: The core/pkg/evaluator/legacy_fractional.go file, which contained the implementation of the deprecated LegacyFractional struct and its evaluation logic, has been entirely removed.
Test Cleanup: The corresponding test file, core/pkg/evaluator/legacy_fractional_test.go, has also been deleted, cleaning up tests for the removed functionality.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request removes the deprecated fractionalEvaluation operator. The changes involve deleting the operator's registration in json.go, and removing the implementation file legacy_fractional.go and its corresponding test file legacy_fractional_test.go. The changes are correct and align with the goal of cleaning up legacy code. The PR is well-executed and I have no suggestions for improvement.

…d with `fractional`. Signed-off-by: NeaguGeorgiana23 <115723925+NeaguGeorgiana23@users.noreply.github.com>

Signed-off-by: NeaguGeorgiana23 <115723925+NeaguGeorgiana23@users.noreply.github.com>

beeme1mr

Thanks, @NeaguGeorgiana23! The docs reference the old fractionalEvaluation but only to explain how to migrate, so I think we can leave it as is.

🤖 I have created a release *beep* *boop* --- <details><summary>flagd: 0.13.0</summary> ## [0.13.0](flagd/v0.12.9...flagd/v0.13.0) (2025-12-23) ### 🐛 Bug Fixes * fixing sync return format missing flag layer, adding full e2e suite ([#1827](#1827)) ([570693d](570693d)) * **security:** update module github.com/go-viper/mapstructure/v2 to v2.4.0 [security] ([#1784](#1784)) ([037e30b](037e30b)) * **security:** update module golang.org/x/crypto to v0.45.0 [security] ([#1826](#1826)) ([7e0762b](7e0762b)) ### ✨ New Features * add support for http-based ofrep metrics ([#1803](#1803)) ([fcd19b3](fcd19b3)) * cleanup evaluator interface ([#1793](#1793)) ([aa504f7](aa504f7)) * enable parsing of array flag configurations for flagd ([#1797](#1797)) ([97c6ffa](97c6ffa)) * multi-project support via selectors and flagSetId namespacing ([#1702](#1702)) ([f9ce46f](f9ce46f)) * normalize selector in sync (use header as in OFREP and RPC) ([#1815](#1815)) ([c1f06cb](c1f06cb)) ### 🧹 Chore * **refactor:** use memdb for flag storage ([#1697](#1697)) ([5c5c1cf](5c5c1cf)) ### 🔄 Refactoring * store cleanup ([#1705](#1705)) ([bcff8d7](bcff8d7)) </details> <details><summary>flagd-proxy: 0.8.1</summary> ## [0.8.1](flagd-proxy/v0.8.0...flagd-proxy/v0.8.1) (2025-12-23) ### 🐛 Bug Fixes * **security:** update module github.com/go-viper/mapstructure/v2 to v2.4.0 [security] ([#1784](#1784)) ([037e30b](037e30b)) * **security:** update module golang.org/x/crypto to v0.45.0 [security] ([#1826](#1826)) ([7e0762b](7e0762b)) </details> <details><summary>core: 0.13.0</summary> ## [0.13.0](core/v0.12.1...core/v0.13.0) (2025-12-23) ### ⚠ BREAKING CHANGES * enable parsing of array flag configurations for flagd ([#1797](#1797)) * cleanup evaluator interface ([#1793](#1793)) * removes the `fractionalEvaluation` operator since it has been replaced with `fractional`. ([#1704](#1704)) ### 🐛 Bug Fixes * **security:** update module github.com/go-viper/mapstructure/v2 to v2.4.0 [security] ([#1784](#1784)) ([037e30b](037e30b)) * **security:** update module golang.org/x/crypto to v0.45.0 [security] ([#1825](#1825)) ([44edcc9](44edcc9)) * **security:** update module golang.org/x/crypto to v0.45.0 [security] ([#1826](#1826)) ([7e0762b](7e0762b)) ### ✨ New Features * Add OAuth support for HTTP Sync ([#1791](#1791)) ([268fd75](268fd75)) * Add OTEL default variables ([#1812](#1812)) ([c2e3fc6](c2e3fc6)) * allow null flagSetId Selector, restrict Selector to single key-value-pairs ([#1708](#1708)) ([#1811](#1811)) ([c12a0ae](c12a0ae)) * change jsonschema parser ([#1794](#1794)) ([bf3f722](bf3f722)) * cleanup evaluator interface ([#1793](#1793)) ([aa504f7](aa504f7)) * enable parsing of array flag configurations for flagd ([#1797](#1797)) ([97c6ffa](97c6ffa)) * multi-project support via selectors and flagSetId namespacing ([#1702](#1702)) ([f9ce46f](f9ce46f)) ### 🧹 Chore * **refactor:** use memdb for flag storage ([#1697](#1697)) ([5c5c1cf](5c5c1cf)) * removes the `fractionalEvaluation` operator since it has been replaced with `fractional`. ([#1704](#1704)) ([3228ad8](3228ad8)) ### 🔄 Refactoring * remove deprecated bearerToken option ([#1816](#1816)) ([efda06a](efda06a)) * removed unused Selector from Flag and Store. ([#1747](#1747)) ([1083005](1083005)) * store cleanup ([#1705](#1705)) ([bcff8d7](bcff8d7)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Signed-off-by: Todd Baert <todd.baert@dynatrace.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Todd Baert <todd.baert@dynatrace.com>

NeaguGeorgiana23 requested a review from a team August 5, 2025 15:05

NeaguGeorgiana23 requested a review from a team as a code owner August 5, 2025 15:05

dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 5, 2025

gemini-code-assist Bot reviewed Aug 5, 2025

View reviewed changes

NeaguGeorgiana23 force-pushed the remove-'fractionalEvaluation' branch from df234da to e455fba Compare August 6, 2025 10:21

NeaguGeorgiana23 added 3 commits August 6, 2025 12:21

removes the fractionalEvaluation operator since it has been replace…

0c4a285

…d with `fractional`. Signed-off-by: NeaguGeorgiana23 <115723925+NeaguGeorgiana23@users.noreply.github.com>

removes the fractionalEvaluation operator since it has been replace…

cf50540

…d with `fractional`. Signed-off-by: NeaguGeorgiana23 <115723925+NeaguGeorgiana23@users.noreply.github.com>

added 'signed-off-by'

7044e28

Signed-off-by: NeaguGeorgiana23 <115723925+NeaguGeorgiana23@users.noreply.github.com>

NeaguGeorgiana23 force-pushed the remove-'fractionalEvaluation' branch from e455fba to 7044e28 Compare August 6, 2025 12:33

beeme1mr changed the title ~~chore: removes the fractionalEvaluation operator since it has been replaced with fractional.~~ chore!: removes the fractionalEvaluation operator since it has been replaced with fractional. Aug 6, 2025

beeme1mr added the breaking label Aug 6, 2025

beeme1mr approved these changes Aug 6, 2025

View reviewed changes

aepfli approved these changes Aug 6, 2025

View reviewed changes

beeme1mr merged commit 3228ad8 into open-feature:main Aug 6, 2025
16 checks passed

github-actions Bot mentioned this pull request Aug 6, 2025

chore: release main #1699

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore!: removes the `fractionalEvaluation` operator since it has been replaced with `fractional`.#1704

chore!: removes the `fractionalEvaluation` operator since it has been replaced with `fractional`.#1704
beeme1mr merged 3 commits into
open-feature:mainfrom
NeaguGeorgiana23:remove-'fractionalEvaluation'

NeaguGeorgiana23 commented Aug 5, 2025 •

edited

Loading

Uh oh!

netlify Bot commented Aug 5, 2025 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

beeme1mr left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

NeaguGeorgiana23 commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

This PR

Related Issues

Uh oh!

netlify Bot commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for polite-licorice-3db33c canceled.

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

beeme1mr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

NeaguGeorgiana23 commented Aug 5, 2025 •

edited

Loading

netlify Bot commented Aug 5, 2025 •

edited

Loading