feat: deprecate flagd-web provider#1459
Conversation
Summary of ChangesHello @toddbaert, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request initiates the deprecation of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request effectively deprecates the flagd-web provider in favor of the OFREP provider. The changes, which include updating the README with a deprecation notice and adding a @deprecated JSDoc tag to the provider class, are well-aligned with this goal. My review includes a suggestion to refine the wording in the README's deprecation notice for improved clarity and conciseness.
|
e2e test is failing due to pre-existing stability issues fixed in a different PR. |
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
24d0541 to
0f4aa53
Compare
|
does this mean, we will also slowly remove the shared directory for flagd and integrate all those things back into the direct flagd provider? |
flagd-core is still useful as a separate component - it's used directly in the playground for example and also in some recent experiments by @jonathannorris to use it in CDN edge workers. |
|
I think we can't proceed with this for now until we have some enhancements to OFREP (or decide not to enhance it) that better support realtime updates via SSE or equivalent... at the very least, the polling needs to be made more efficient. Related: open-feature/flagd#1858 |
This PR deprecates the flagd-web provider. The OFREP provider provides comparable functionality over HTTP and, is fully supported by flagd.
There's one significant feature we should release in flagd first before we truly have equivalent features: open-feature/flagd#1854