feat: invalidate etag on context change

[toddbaert]

See: open-feature/flagd#1858

We can do some very aggressive and efficient caching if we make this simple change, basically using the ETag to prevent re-evaluations (the server will send 304 unless the servers flag config has changed). But, after context changes, we need to remove this so that we force-reevaluation with the new context.

I'm not sure if we should spec this somehow, is there a spec somewhere for OFREP client providers?

[gemini-code-assist]

Summary of Changes

Hello @toddbaert, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a crucial enhancement to the OFREPWebProvider by ensuring that cached data, identified by an ETag, is invalidated whenever the evaluation context changes. This prevents the use of stale data and guarantees that feature flag evaluations are always based on the most current context, improving data consistency and reliability.

Highlights

• ETag Invalidation: The _etag property is now explicitly set to null within the onContextChange method of the OFREPWebProvider. This ensures that a new ETag is fetched, forcing a refetch of data when the evaluation context changes.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request introduces a crucial change by invalidating the ETag when the evaluation context changes. This ensures that the provider always fetches the latest flag configurations from the OFREP API when the context is updated, preventing the use of stale cached data. This is a correct and necessary enhancement for maintaining data consistency and accuracy in flag evaluations.