Skip to content

chore: Update FeatureProvider to SMP#35

Closed
maxnrp wants to merge 3 commits into
open-feature:mainfrom
maxnrp:make-smp-compatible
Closed

chore: Update FeatureProvider to SMP#35
maxnrp wants to merge 3 commits into
open-feature:mainfrom
maxnrp:make-smp-compatible

Conversation

@maxnrp
Copy link
Copy Markdown
Contributor

@maxnrp maxnrp commented Apr 28, 2026

Summary

Align kotlin-sdk-contrib with kotlin-sdk APIs: StateManagingProvider lifecycle, getLongEvaluation, and Value.Long support. Intended to merge once the matching dev.openfeature:kotlin-sdk release is on Maven Central (update gradle/libs.versions.toml accordingly).

Changes

  • EnvVarProvider / OfrepProvider: implement StateManagingProvider via ProviderStatusTracker (status, observe(), lifecycle events).

  • getLongEvaluation on both providers; OFREP Value.toPrimitive / ValueSerializer updated for Long.

  • EnvVarProvider.onContextSet: ProviderReconcilingyield()ProviderReady.

  • OfrepProvider: lifecycle routed through statusTracker; shutdown emits not-ready ProviderError.

maxnrp added 2 commits April 28, 2026 15:20
Signed-off-by: Max Pinheiro <max.pinheiro@fluxon.com>
Signed-off-by: Max Pinheiro <max.pinheiro@fluxon.com>
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the open-feature-kotlin-sdk to version 0.8.0 and refactors the OfrepProvider to utilize the updated event system, including the use of EventDetails for error reporting. Corresponding unit tests have been updated to validate these event details. Feedback indicates that the provider's lifecycle management is incomplete, as the shutdown method lacks an event emission to signal the provider is no longer ready, and the class does not yet implement the StateManagingProvider interface as expected.

Signed-off-by: Max Pinheiro <max.pinheiro@fluxon.com>
@maxnrp maxnrp force-pushed the make-smp-compatible branch from ca9fcf8 to 7f8104e Compare April 28, 2026 17:22
@maxnrp maxnrp changed the title chore: Make SMP compatible chore: Update FeatureProvider to SMP Apr 28, 2026
@bencehornak
Copy link
Copy Markdown
Contributor

We can close #34 in favor of this one, bc this one contains that fully, doesn't it? I've left a comment there nonetheless

@maxnrp
Copy link
Copy Markdown
Contributor Author

maxnrp commented Apr 30, 2026

We can close #34 in favor of this one, bc this one contains that fully, doesn't it? I've left a comment there nonetheless

I opened this PR with the pessimistic assumption that it wouldn’t be reviewed so soon. It depends on #241, which hasn’t been merged and released yet, so I’m closing it for now and will reopen it later.

@maxnrp maxnrp closed this Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants