Skip to content

fix: Align FeatureFlagSource CRD defaults with documentation #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
beeme1mr merged 5 commits into from
May 5, 2026
Merged

fix: Align FeatureFlagSource CRD defaults with documentation #838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
eab634c
Align defaults with documentation and generate CRDs
Y0sh1dk May 5, 2026
09cbf0a
Update api/core/v1beta1/featureflagsource_types.go
Y0sh1dk May 5, 2026
3cb7299
Update api/core/v1beta1/featureflagsource_types.go
Y0sh1dk May 5, 2026
7a3170f
Update api/core/v1beta1/featureflagsource_types.go
Y0sh1dk May 5, 2026
c08f437
Regenerate CRD docs
Y0sh1dk May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions api/core/v1beta1/featureflagsource_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,14 +76,17 @@ type FeatureFlagSourceSpec struct {
// RolloutOnChange dictates whether annotated deployments will be restarted when configuration changes are
// detected in this CR, defaults to false
// +optional
// +kubebuilder:default:=false
RolloutOnChange *bool `json:"rolloutOnChange"`

// ProbesEnabled defines whether to enable liveness and readiness probes of flagd sidecar. Default true (enabled).
// +optional
// +kubebuilder:default:=true
ProbesEnabled *bool `json:"probesEnabled"`

// DebugLogging defines whether to enable --debug flag of flagd sidecar. Default false (disabled).
// +optional
// +kubebuilder:default:=false
DebugLogging *bool `json:"debugLogging"`

// OtelCollectorUri defines whether to enable --otel-collector-uri flag of flagd sidecar. Default false (disabled).
Expand Down Expand Up @@ -146,8 +149,7 @@ type Source struct {
}

// FeatureFlagSourceStatus defines the observed state of FeatureFlagSource
type FeatureFlagSourceStatus struct {
}
type FeatureFlagSourceStatus struct{}

//+kubebuilder:resource:shortName="ffs"
//+kubebuilder:object:root=true
Expand Down
3 changes: 3 additions & 0 deletions config/crd/bases/core.openfeature.dev_featureflagsources.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ spec:
type: string
type: array
debugLogging:
default: false
description: DebugLogging defines whether to enable --debug flag of
flagd sidecar. Default false (disabled).
type: boolean
Expand Down Expand Up @@ -222,6 +223,7 @@ spec:
format: int32
type: integer
probesEnabled:
default: true
description: ProbesEnabled defines whether to enable liveness and
readiness probes of flagd sidecar. Default true (enabled).
type: boolean
Expand Down Expand Up @@ -286,6 +288,7 @@ spec:
type: object
type: object
rolloutOnChange:
default: false
description: |-
RolloutOnChange dictates whether annotated deployments will be restarted when configuration changes are
detected in this CR, defaults to false
Expand Down
6 changes: 6 additions & 0 deletions docs/crds.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,8 @@ FeatureFlagSourceSpec defines the desired state of FeatureFlagSource
<td>boolean</td>
<td>
DebugLogging defines whether to enable --debug flag of flagd sidecar. Default false (disabled).<br/>
<br/>
<i>Default</i>: false<br/>
</td>
<td>false</td>
</tr><tr>
Expand Down Expand Up @@ -388,6 +390,8 @@ are added at the lowest index, all values will have the EnvVarPrefix applied, de
<td>boolean</td>
<td>
ProbesEnabled defines whether to enable liveness and readiness probes of flagd sidecar. Default true (enabled).<br/>
<br/>
<i>Default</i>: true<br/>
</td>
<td>false</td>
</tr><tr>
Expand All @@ -403,6 +407,8 @@ are added at the lowest index, all values will have the EnvVarPrefix applied, de
<td>
RolloutOnChange dictates whether annotated deployments will be restarted when configuration changes are
detected in this CR, defaults to false<br/>
<br/>
<i>Default</i>: false<br/>
</td>
<td>false</td>
</tr><tr>
Expand Down
Loading