Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors a feature flag from offer-free-shipping to the more descriptive free-shipping-banner and updates its usage throughout the application. The changes also improve the generated OpenFeature hooks file by adding explicit return types and introducing a FlagKeys object to centralize flag keys. These are great improvements for maintainability. My review includes suggestions to further enhance the code by removing an unused import and consistently using the new FlagKeys constants within the hook implementations to eliminate magic strings.
🚀 OpenFeature Manifest Comparison (validate-flags)Warning Remote Push Preview - The following changes will be applied to the remote flag service ( 📊 Change Summary
📋 View detailed changes🟢 Flags That Will Be Added (1)🟢 🔄 View manifest diff@@ -1,20 +1,15 @@
{
"$schema": "https://raw.githubusercontent.com/open-feature/cli/refs/heads/main/schema/v0/flag-manifest.json",
"flags": {
- "free-shipping-banner": {
- "flagType": "boolean",
- "description": "Controls the free shipping banner on the website. SHOP-4287",
- "defaultValue": false
- },
"offer-free-shipping": {
- "flagType": "boolean",
+ "defaultValue": false,
"description": "Add free shipping to the UI.",
- "defaultValue": false
+ "flagType": "boolean"
},
"sticky-header": {
- "flagType": "boolean",
+ "defaultValue": false,
"description": "Make the header stay at the top of the page while scrolling.",
- "defaultValue": false
+ "flagType": "boolean"
},
"use-distributed-db": {
"defaultValue": true,💡 This preview shows what will change in the remote flag service when you push your local manifest This comment is automatically updated on each push |
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
33909fe to
d2d6b66
Compare
This is a demo for KubeCon