Skip to content

feat: add free shipping banner#35

Closed
beeme1mr wants to merge 1 commit intomainfrom
shop-4287/add-shipping-banner
Closed

feat: add free shipping banner#35
beeme1mr wants to merge 1 commit intomainfrom
shop-4287/add-shipping-banner

Conversation

@beeme1mr
Copy link
Copy Markdown
Member

@beeme1mr beeme1mr commented Nov 6, 2025

This is a demo for KubeCon

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors a feature flag from offer-free-shipping to the more descriptive free-shipping-banner and updates its usage throughout the application. The changes also improve the generated OpenFeature hooks file by adding explicit return types and introducing a FlagKeys object to centralize flag keys. These are great improvements for maintainability. My review includes suggestions to further enhance the code by removing an unused import and consistently using the new FlagKeys constants within the hook implementations to eliminate magic strings.

Comment thread src/generated/react/openfeature.ts Outdated
Comment thread src/generated/react/openfeature.ts Outdated
Comment thread src/generated/react/openfeature.ts Outdated
Comment thread src/generated/react/openfeature.ts Outdated
Comment thread src/generated/react/openfeature.ts Outdated
Comment thread src/generated/react/openfeature.ts Outdated
Comment thread src/generated/react/openfeature.ts Outdated
Comment thread src/generated/react/openfeature.ts Outdated
Comment thread src/generated/react/openfeature.ts Outdated
@beeme1mr beeme1mr closed this Nov 6, 2025
@beeme1mr beeme1mr reopened this Nov 6, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 6, 2025

🚀 OpenFeature Manifest Comparison (validate-flags)

Warning

Remote Push Preview - The following changes will be applied to the remote flag service (https://flagd-studio.onrender.com/api) when your manifest is pushed

📊 Change Summary

Change Type Count Description
🟢 Additions 1 Flags that will be added to remote
🔴 Removals 0 Flags that will be removed from remote
🟡 Modifications 0 Flags that will be modified in remote
Total 1 Total differences
📋 View detailed changes

🟢 Flags That Will Be Added (1)

🟢 free-shipping-banner

🔄 View manifest diff
@@ -1,20 +1,15 @@
 {
   "$schema": "https://raw.githubusercontent.com/open-feature/cli/refs/heads/main/schema/v0/flag-manifest.json",
   "flags": {
-    "free-shipping-banner": {
-      "flagType": "boolean",
-      "description": "Controls the free shipping banner on the website. SHOP-4287",
-      "defaultValue": false
-    },
     "offer-free-shipping": {
-      "flagType": "boolean",
+      "defaultValue": false,
       "description": "Add free shipping to the UI.",
-      "defaultValue": false
+      "flagType": "boolean"
     },
     "sticky-header": {
-      "flagType": "boolean",
+      "defaultValue": false,
       "description": "Make the header stay at the top of the page while scrolling.",
-      "defaultValue": false
+      "flagType": "boolean"
     },
     "use-distributed-db": {
       "defaultValue": true,

💡 This preview shows what will change in the remote flag service when you push your local manifest

This comment is automatically updated on each push

Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
@beeme1mr beeme1mr force-pushed the shop-4287/add-shipping-banner branch from 33909fe to d2d6b66 Compare November 8, 2025 13:37
@beeme1mr beeme1mr closed this Nov 8, 2025
@beeme1mr beeme1mr deleted the shop-4287/add-shipping-banner branch November 10, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant