#6418 support 'referentie' attribute when updating Customer Interactions API - #6486
Draft
annashamray wants to merge 3 commits into
Draft
#6418 support 'referentie' attribute when updating Customer Interactions API#6486annashamray wants to merge 3 commits into
annashamray wants to merge 3 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6486 +/- ##
==========================================
- Coverage 97.22% 97.21% -0.02%
==========================================
Files 860 860
Lines 33061 33066 +5
Branches 2999 3001 +2
==========================================
+ Hits 32143 32144 +1
- Misses 606 608 +2
- Partials 312 314 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The tests are failing because Open Klant doesn't have the needed change implemented. After the new Open Klant version is released, the supported vertsion in the docs should be updated and VCR cassettes should be re-recorded
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6418
Depends on maykinmedia/open-klant-client#8
Blocked by maykinmedia/open-klant#625
Changes
What's left to do:
digitalAdres.referentiein Open FormsHere are all user flows for profile component. Updates are added in bold
The flows of using "profile component"
contactMoment,betrokkeneandonderwerpObjectdigitaalAdresrecords linked to the createdbetrokkenepartijfor the usercontactMoment,betrokkeneandonderwerpObjectand linkbetrokkeneto the created
partijdigitaalAdresrecords linked to the createdbetrokkene. If the address issubmitted as
isNewPreferred, then it's also linked to the createdpartijisNewPreferred, itsreferentieis includedpartijfor the usercontactMoment,betrokkeneandonderwerpObjectand linkbetrokkeneto the found
partijdigitaalAdresrecords linked to the createdbetrokkeneif the used address is not defaultpartijfor the usercontactMoment,betrokkeneandonderwerpObjectand linkbetrokkeneto the found
partijdigitaalAdresrecords linked to the createdbetrokkenefor the new addresses.If the address is submitted as
isNewPreferred, then it's also linked to thepartijisNewPreferred, itsreferentieis includedpartijfor the usercontactMoment,betrokkeneandonderwerpObjectand linkbetrokkeneto the found
partijuseOnlyOnce, then we don't update itisNewPreferred, and the existing address is notpreferred (
isStandaardAdres== False) then we update it withisStandaardAdres= TrueisNewPreferred, itsreferentieis updatedChecklist
Check off the items that are completed or not relevant.
Impact on features
Dockerfile/scripts
./binfolderCommit hygiene
Documentation