Fix logic actions saving that have a form step reference - #6638
Open
sergei-maertens wants to merge 5 commits into
Open
Fix logic actions saving that have a form step reference#6638sergei-maertens wants to merge 5 commits into
sergei-maertens wants to merge 5 commits into
Conversation
The v3 serializer expects a slug as reference to the form step rather than the UUID (which is not yet available for newly created steps).
It's not really dummy data, but logic actions data that targets steps.
Because we use the form step slug as reference in the v3 endpoint and frontend code (to account for the missing step UUID for newly created steps), the logic rule processing code crashed as for the disable next, mark applicable and mark not applicable actions a step reference is required, which must be step UUID rather than a slug. This patch performs the mapping from slug to UUID and updates the action configuration at save-time (update/create) to make sure the internal data matches what the runtime logic execution expects.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6638 +/- ##
=======================================
Coverage 97.26% 97.26%
=======================================
Files 859 859
Lines 33312 33316 +4
Branches 3004 3004
=======================================
+ Hits 32400 32404 +4
Misses 603 603
Partials 309 309 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was reported in person by Laurens.
Checklist
Check off the items that are completed or not relevant.
Impact on features
Dockerfile/scripts
./binfolderCommit hygiene
Documentation