Add gotcha about Api Gateway WebSocket Apis with Api Key header#772
Open
matthias-pichler wants to merge 1 commit intoopen-guides:masterfrom
Open
Add gotcha about Api Gateway WebSocket Apis with Api Key header#772matthias-pichler wants to merge 1 commit intoopen-guides:masterfrom
matthias-pichler wants to merge 1 commit intoopen-guides:masterfrom
Conversation
Author
|
The check 👇 failed for old links |
darigovresearch
approved these changes
Sep 25, 2022
Contributor
darigovresearch
left a comment
darigovresearch
left a comment
There was a problem hiding this comment.
@matthias-pichler-warrify thanks for taking the time to make the pull request. Think having the gotcha is helpful, the only minor suggestion would be to capitalise API in the rest of your sentence for consistency.
Do any of the maintainers require anything else for this pull request to be merged?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added one of the Gotchas of Api Gateway WebSocket Apis that definitely got our team. I am also considering adding one about the fact that a custom Authorizer can only be added to the
$connectroute which is basically the follow up Gotcha to this one.