Fix CWE-73: File Manipulation #75
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yummikko
force-pushed
the
fix_file_manipulation
branch
from
49c1a5c to
7e46b12
Compare
Signed-off-by: Aleksandra Chyła <[email protected]>
Yummikko
force-pushed
the
fix_file_manipulation
branch
from
6a89d38 to
6333f32
Compare
kroczi
reviewed
May 15, 2025
Comment on lines
-428
to
+437
| fileName := deviceDir + "/ownership_voucher.txt" | ||
| fileName := filepath.Clean(filepath.Join(deviceDir, "ownership_voucher.txt")) | ||
| outils.Verbose("POST /api/orgs/%s/fdo/vouchers: creating %s ...", deviceOrgId, fileName) | ||
| if err := ioutil.WriteFile(filepath.Clean(fileName), bodyBytes, 0644); err != nil { | ||
| if err := os.WriteFile(fileName, bodyBytes, 0644); err != nil { | ||
| http.Error(w, "could not create "+fileName+": "+err.Error(), http.StatusInternalServerError) | ||
| return | ||
| } | ||
|
|
||
| // Create orgid.txt file to identify what org this device/voucher is part of | ||
| fileName = deviceDir + "/orgid.txt" | ||
| fileName = filepath.Clean(filepath.Join(deviceDir, "orgid.txt")) |
There was a problem hiding this comment.
you can use Clean() where the deviceDir is defined (line 422) and skip subsequent Clean() calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CWE Description
File Manipulation vulnerability occurs when an application allows user input to control or influence paths or file names that are used in file system operations. This could allow an attacker to access or modify system files or other files that are critical to the application. For example, an application may give an attacker the ability to overwrite a specified file or run with a configuration controlled by the attacker