add health check to dockerfiles #4346
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenyang-cao
force-pushed
the
fix-vul-healthcheck
branch
from
90528f9 to
ea90b05
Compare
omordyk
approved these changes
May 22, 2025
kroczi
reviewed
May 26, 2025
| @@ -6,3 +6,4 @@ ADD cloud-sync-service /cloud-sync-service/ | |||
|
|
|||
| CMD ["/cloud-sync-service/cloud-sync-service"] | |||
|
|
|||
| HEALTHCHECK --interval=30s --timeout=5s --retries=3 CMD grep -q css_start.sh /proc/1/cmdline || exit 1 | |||
There was a problem hiding this comment.
OK. I'll update this for all images later.
| @@ -6,3 +6,4 @@ ADD cloud-sync-service /cloud-sync-service/ | |||
|
|
|||
| CMD ["/cloud-sync-service/cloud-sync-service"] | |||
|
|
|||
| HEALTHCHECK --interval=30s --timeout=5s --retries=3 CMD grep -q css_start.sh /proc/1/cmdline || exit 1 | |||
There was a problem hiding this comment.
in some images you use grep ... /proc/1/cmdline, in other pgrep - could this be unified?
There was a problem hiding this comment.
Some images don't have pgrep. Nor do they have ps so I cannot use ps to get the process name. That is why I am using grep ... /proc/1/cmdline for these images
added 2 commits
May 28, 2025 07:41
Signed-off-by: Wenyang Cao <[email protected]>
Signed-off-by: Wenyang Cao <[email protected]>
wenyang-cao
force-pushed
the
fix-vul-healthcheck
branch
from
ea90b05 to
a7f2e7d
Compare
|
@omordyk @wenyang-cao Can we go ahead and cancel this PR ? Health checks are provided elsewhere |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
One of the important security triads is availability. Adding HEALTHCHECK instruction to your container image ensures that the docker engine periodically checks the running container instances against that instruction to ensure that the instances are still working.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Build and run the images (except the ones for k8s, since k8s has its own liveness probe and I cannot really see if health check is working in this case, but adding health check to k8s images is still required for twistlick) locally to verify the health check is working.
Additional Context (Please include any Screenshots/gifs if relevant)
...
Checklist: