Skip to content

chat: smoother share dialog translations (fixes #5458) #5459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chat: smoother share dialog translations (fixes #5458) #5459

wants to merge 2 commits into from

Conversation

huitk
Copy link
Member

@huitk huitk commented Mar 11, 2025

fixes #5458
Screenshot 2025-03-11 at 1 41 48 PM

@huitk huitk linked an issue Mar 11, 2025 that may be closed by this pull request
chat: inconsistent capitalization #5458
Open
pavi38
pavi38 requested changes Mar 11, 2025
View reviewed changes
Copy link
Member

@pavi38 pavi38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @huitk everything else looks good. But you shouldn't change the gradle version.

@huitk
Copy link
Member Author

huitk commented Mar 11, 2025

@pavi38 That version doesn't compatible with my emulator and unable to run using the newer version. I will change it back.

@dogi dogi changed the title chat: smoother capitalization (fixes #5458) chat: smoother buttons translations (fixes #5458) Mar 17, 2025
@dogi dogi changed the title chat: smoother buttons translations (fixes #5458) chat: smoother share dialog translations (fixes #5458) Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deeppp15 deeppp15 deeppp15 approved these changes

@pavi38 pavi38 pavi38 approved these changes

@Avinash-Codes Avinash-Codes Avinash-Codes approved these changes

Assignees
No one assigned
Labels
don't merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chat: inconsistent capitalization
5 participants
@huitk @deeppp15 @pavi38 @Avinash-Codes @dogi