teams: smoother list button spacing (fixes #9199)#9246
Merged
Conversation
emmanuelbaa
approved these changes
Oct 21, 2025
Mutugiii
requested changes
Oct 22, 2025
|
|
||
| .mat-cell button, .mat-cell div button[mat-raised-button] { | ||
| width: 150px; | ||
| width: 120px; |
Member
There was a problem hiding this comment.
Not sure we want to switch to 120px as this means the Request to Join text will always be cutoff
Comment on lines
+58
to
+65
| .mat-cell button, .mat-cell div button[mat-raised-button] { | ||
| width: 100px; | ||
| text-align: center; | ||
| padding: 6px 10px; | ||
| white-space: nowrap; | ||
| overflow: hidden; | ||
| text-overflow: ellipsis; | ||
| } |
Member
There was a problem hiding this comment.
Save for the width. These styles are redundant as they are already defined here: https://github.com/open-learning-exchange/planet/pull/9246/files#diff-8c74067557964ea1db81e4e963316ae806c1219a8272462d18ff68f179b4038fR35-R42
Saby-Bishops
commented
Oct 28, 2025
Saby-Bishops
left a comment
Saby-Bishops
left a comment
Member
Author
There was a problem hiding this comment.
All the requested changes are addressed, please do review again. Thanks.
Mutugiii
approved these changes
Oct 28, 2025
dogi
changed the title
dogi
approved these changes
Oct 29, 2025
dogi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #9199
Summary
https://chatgpt.com/codex/tasks/task_e_68f2a18467ec832d9ba7ca4e240b0cb1