enterprises: smoother finances pictures attaching (fixes #9966)#9975
Merged
Conversation
Mutugiii
changed the title
Member
Author
|
@codex review |
There was a problem hiding this comment.
Pull request overview
Adds support for attaching (up to two) optional receipt images to team financial transactions and financial reports, including upload UI, display indicators/previews, and CouchDB attachment handling.
Changes:
- Introduces a reusable
file-uploadfield type in the generic dialogs form, backed by the existingplanet-file-uploadcomponent. - Adds
TeamsAttachmentsServiceto list/retain/upload receipt image attachments in CouchDB. - Updates Teams finances and reports UIs to upload receipt images and display receipt indicators/previews.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/app/teams/teams-view-finances.scss | Styles receipt image link icons in the transactions table. |
| src/app/teams/teams-view-finances.component.ts | Adds receipt image upload handling when creating/updating transactions. |
| src/app/teams/teams-view-finances.component.html | Displays receipt image links/icons per transaction row. |
| src/app/teams/teams-reports.scss | Styles receipt image count indicator on report cards. |
| src/app/teams/teams-reports.component.ts | Adds receipt image upload handling when creating/updating reports. |
| src/app/teams/teams-reports.component.html | Shows receipt image count on report cards. |
| src/app/teams/teams-reports-detail.scss | Adds layout styles for a receipt image grid in report details. |
| src/app/teams/teams-reports-detail.component.ts | Loads receipt image attachment list for report detail display. |
| src/app/teams/teams-reports-detail.component.html | Displays receipt image preview grid with links in report summary view. |
| src/app/teams/teams-attachments.service.ts | New service for filtering/uploading receipt image attachments. |
| src/app/shared/dialogs/dialogs-form.service.ts | Extends dialog field definitions to support file-upload. |
| src/app/shared/dialogs/dialogs-form.component.ts | Wires file upload state changes into the reactive form model. |
| src/app/shared/dialogs/dialogs-form.component.html | Renders planet-file-upload for file-upload dialog fields. |
| src/app/shared/couchdb.service.ts | Adds a helper to fetch attachments as Blob for re-uploading retained files. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Mutugiii
changed the title
dogi
changed the title
dogi
changed the title
dogi
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9966
Add optional finances & report attachments.
Limited to 2 images.