refactor: Domain and Data Product UI improvements and architecture enhancements #23804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hancements ## Major Changes ### Architecture Improvements - **Refactored AssetSelectionModal**: Split monolithic component into composable hooks - Extracted `useAssetSelectionContent` hook (806 lines) for shared selection logic - Created `AssetSelectionDrawer` component for drawer variant - Reduced main modal component from 700+ to 18 lines - Enables reuse across modal and drawer UI patterns - **Domain component reorganization**: - Renamed `DomainDetailsPage` → `DomainDetails` for consistency - Deleted legacy `DomainPage.component.tsx` (336 lines) - Centralized domain page styles in `DomainPageStyles.ts` ### UI/UX Enhancements - **Breadcrumbs**: Changed to plural labels across all pages - "Domain" → "Domains" in listings and detail pages - "Data Product" → "Data Products" in listings and detail pages - Updated sidebar navigation labels to match - **Scroll behavior fixes**: - Removed fixed height constraints causing nested scrolls in right panels - Changed from `height: @domain-page-height` to `min-height: 70vh` - Applied to both Domain (domain.less) and Data Product (data-products-details-page.less) detail pages - Now uses single body scroll for better UX - **Visual improvements**: - Added white text color to MUI tooltips for better contrast on black background - Enhanced GenericProvider with `muiTags` prop support - Added new `CoverImage` component for domain/data product headers - Improved `useBreadcrumbs` hook with 187 lines of enhancements ### Bug Fixes - **TypeScript errors in NotistackUtils.tsx**: - Fixed implicit 'any' type for `snackbarId` parameters (4 instances) - Added type assertion for i18n.t() return value - All type errors resolved ### Component Improvements - Enhanced TagsViewer with MUI tooltip support - Updated TagChip component for better tag display - Improved EntityAvatar component - Refined drawer hooks with better type safety
satishwaghela
added
the
safe to test
|
The Python checkstyle failed. Please run You can install the pre-commit hooks with |
Jest test CoverageUI tests summary
|
- Add MUICoverImageUpload component with drag-and-drop support - Implement vertical reposition functionality for cover images - Integrate cover image field in AddDomainForm - Update CoverImage component to support position object format - Add COVER_IMAGE_UPLOAD_MUI field type to form utils - Support empty entityLink for uploads during domain creation - Add translations for cover image upload UI 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
The Python checkstyle failed. Please run You can install the pre-commit hooks with |
- Update DomainDetails and DataProductsDetailsPage to pass cover image URL and position to CoverImage component - Implement authenticated image loading with proper loading states in CoverImage component - Add gray background during authenticated image loading to prevent 401 error flash - Implement conditional rendering in MUICoverImageUpload to show loading spinner for authenticated images - Add comprehensive data-testid attributes for both components to improve testability - Use theme colors for loading backgrounds instead of hardcoded values 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Create reusable createEntityWithCoverImage utility function - Refactor domain, subdomain, and data product creation to use generic function - Fix cover image preview and reposition functionality for client-side handling - Remove unused AddDomain component and /domain/add route - Remove dead DomainLeftPanel component - Reduce code duplication by 77% (344 lines → 79 lines) - Add proper TypeScript types and ESLint compliance 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Update CoverImageUploadUtils to send coverImage as nested object
- Change from flat structure (coverImage: url, coverImagePosition: number)
- Change to nested structure (coverImage: { url: string, position: string })
- Update DomainDetails to read from nested coverImage object
- Update DataProductsDetailsPage to read from nested coverImage object
- Convert position between CSS string format ("20px") and pixel number (20)
- Fix DomainRouter test by removing deleted AddDomain component references
- Add type assertions for compatibility until backend types are regenerated
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major Changes
Architecture Improvements
Refactored AssetSelectionModal: Split monolithic component into composable hooks
useAssetSelectionContenthook (806 lines) for shared selection logicAssetSelectionDrawercomponent for drawer variantDomain component reorganization:
DomainDetailsPage→DomainDetailsfor consistencyDomainPage.component.tsx(336 lines)DomainPageStyles.tsUI/UX Enhancements
Breadcrumbs: Changed to plural labels across all pages
Scroll behavior fixes:
height: @domain-page-heighttomin-height: 70vhVisual improvements:
muiTagsprop supportCoverImagecomponent for domain/data product headersuseBreadcrumbshook with 187 lines of enhancementsBug Fixes
snackbarIdparameters (4 instances)Component Improvements
Describe your changes:
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>