Skip to content

Conversation

chirag-madlani
Copy link
Collaborator

@chirag-madlani chirag-madlani commented Oct 10, 2025

This pull request introduces improvements to Playwright test configuration and refactors the CustomizeDetailPage.spec.ts test for better reliability and maintainability. The main changes focus on increasing test robustness and refining test selection and execution.

Playwright test configuration updates:

  • Increased test repetition by setting repeatEach: 10 in playwright.config.ts, allowing each test to run 10 times for improved flakiness detection.
  • Restricted the customize-application project to only run CustomizeDetailPage.spec.ts and PersonaFlow.spec.ts by updating testMatch, ensuring targeted execution.

Test reliability and code cleanup:

  • Refactored the persona navigation in CustomizeDetailPage.spec.ts to wait for the persona list API response and use pagination-aware navigation, improving reliability when clicking persona cards.
  • Removed unnecessary import of waitForAllLoadersToDisappear from the test file, as loader waiting is now handled differently.
  • Minor import order adjustment for consistency in CustomizeDetailPage.spec.ts.
Screenshot 2025-10-13 at 5 31 31 PM Screenshot 2025-10-13 at 5 34 44 PM

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

github-actions bot commented Oct 10, 2025

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
63.46% (46286/72940) 40.71% (21864/53712) 43.74% (6958/15907)

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants