Skip to content

Conversation

Rohit0301
Copy link
Contributor

Describe your changes:

Problem:
Mentions made inside Incidents or Entities were not appearing in the Notifications → Mentions tab.

Root causes:

  • The mentions API in Notifications was using a hard filter: type = conversation, which excluded Incident mentions.
  • Incidents use type = task, and the Mentions tab logic was not handling that type.

Changes made:

  1. Removed the type = conversation filter from the Mentions API call.

    • This allows mentions from Incidents, Conversations, and Entities to appear.
  2. Mapped type task to conversation for rendering

    • Only for the Mentions tab UI, task-based mentions are treated as conversation types.
    • This prevents them from showing as “task assigned” notifications.

Fixes #23223

Screenshot 2025-10-13 at 7 58 12 PM

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

1 similar comment
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
63.36% (46183/72890) 40.54% (21748/53647) 43.67% (6944/15901)

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mentions not shown when tagging somoeoe in incidents, conversations..

2 participants