Add enable toggle to test-connection pod - #505
Open
nickozilla wants to merge 1 commit into
Open
Conversation
akash-jain-10
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it :
Add
testConnection.enabledflag to conditionally deploy test connection podThe test-connection pod is a Helm test hook intended for validating connectivity during chart development and testing. It should not run in production environments.
This change adds a testConnection.enabled value (defaults to true for backwards compatibility) that gates whether the pod manifest is rendered at all.
Changes
Context: This chart is deployed via helm template + kustomize rather than helm install. In that workflow, Helm hook annotations (helm.sh/hook: test) are not honoured — all rendered resources are applied directly to the cluster.
The test connection pod was therefore being deployed unconditionally on every upgrade. Adding testConnection.enabled (defaulting to true) allows it to be disabled in environments where it should not run.
Type of change :
Checklist:
Reviewers