Skip to content

Derive compatible compute type in the case of CPU use #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 3, 2025

Conversation

3manifold
Copy link
Contributor

@3manifold 3manifold commented Jan 13, 2025

Description

Fix error occurring because of the unsupported default compute type (float16) in the case of CPU use. Furthermore, automatically derive the compatible compute type (int8) on a CPU-only system.

See relevant issue for further details. resolves #384

@3manifold 3manifold marked this pull request as ready for review January 13, 2025 09:28
@3manifold 3manifold changed the title Derive the compatible compute type in the case of CPU use Derive compatible compute type in the case of CPU use Jan 13, 2025
@yuantuo666
Copy link
Collaborator

Hi, please install "black" package and format your code.

@3manifold
Copy link
Contributor Author

Hi, please install "black" package and format your code.

Updated

@3manifold 3manifold force-pushed the compute-type-CPU-fix branch from 0df807b to 1de9aa7 Compare March 3, 2025 10:15
@yuantuo666 yuantuo666 requested a review from HarryHe11 March 3, 2025 12:24
Copy link
Collaborator

@yuantuo666 yuantuo666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuantuo666 yuantuo666 merged commit f25ba32 into open-mmlab:main Mar 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Fix unsupported default compute type in the case of CPU use
2 participants