support evaluation on vehicleid #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
March 10, 2021 21:57
|
improve codes for supporting vehicleid |
yxgeee
reviewed
Apr 15, 2021
| @@ -311,7 +314,7 @@ def save(self, mAP=None): | |||
| self._best_mAP = max(self._best_mAP, mAP) | |||
| print( | |||
| bcolors.OKGREEN | |||
| + "\n * Finished epoch {:3d} mAP: {:5.1%} best: {:5.1%}{}\n".format( | |||
| + "\n * Finished epoch {:3d} current: {:5.1%} best: {:5.1%}{}\n".format( | |||
There was a problem hiding this comment.
"current" here is not so good, please specify whether the metric is mAP or CMC here.
yxgeee
reviewed
Apr 15, 2021
|
|
||
|
|
||
| @torch.no_grad() | ||
| def final_test(cfg, model, cmc_topk=(1, 5, 10)): |
There was a problem hiding this comment.
The module name "final_test" is somehow confusing. Maybe you could modify the original "test_reid" into "test_reid_once" and "final_test" into "test_reid".
yxgeee
reviewed
Apr 15, 2021
| for idx in range(len(runner.model)): | ||
| print("==> Test on the no.{} model".format(idx)) | ||
| # test_reid() on self.model[idx] will only evaluate the 'mean_net' | ||
| # for testing 'net', use self.model[idx].module.net |
There was a problem hiding this comment.
The comments need to be modified accordingly.
yxgeee
reviewed
Apr 15, 2021
| @@ -50,6 +50,9 @@ TRAIN: | |||
| datasets: {'market1501': 'trainval', 'dukemtmcreid': 'trainval'} | |||
| unsup_dataset_indexes: [1,] | |||
|
|
|||
| # repeated number of evaluation | |||
| num_repeat: 10 # 10 only for vehicleid dataset, otherwise 1 | |||
There was a problem hiding this comment.
Here should be "1" I guess?
yxgeee
reviewed
Apr 15, 2021
| epochs: 50 | ||
| iters: 400 | ||
| iters: 800 |
There was a problem hiding this comment.
As you use market-1501 in this config, the iters should be 400.
|
Hi Zhiwei, thanks for your pulling requests. I have made some comments, please check and modify the requests accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.