Skip to content

[Enhance] Add auto scale lr for maskformer_swin_l #8385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

chhluo
Copy link
Collaborator

@chhluo chhluo commented Jul 19, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

  1. update setting of auto_scale_lr in maskformer_swin_l and strong_baseline which have batch_size= 64
  2. rename config files in lad which have batch_size = 2 x 8 not 8 x 8.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #8385 (402add8) into dev (a5f9ed3) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 402add8 differs from pull request most recent head 367bc32. Consider uploading reports for the commit 367bc32 to get more accurate results

@@            Coverage Diff             @@
##              dev    #8385      +/-   ##
==========================================
+ Coverage   64.17%   64.18%   +0.01%     
==========================================
  Files         361      361              
  Lines       29527    29527              
  Branches     5019     5019              
==========================================
+ Hits        18949    18952       +3     
+ Misses       9575     9574       -1     
+ Partials     1003     1001       -2     
Flag Coverage Δ
unittests 64.15% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/core/hook/wandblogger_hook.py 15.04% <0.00%> (ø)
mmdet/models/roi_heads/mask_heads/maskiou_head.py 89.65% <0.00%> (+2.29%) ⬆️
mmdet/utils/misc.py 64.10% <0.00%> (+2.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5f9ed3...367bc32. Read the comment docs.

@hhaAndroid
Copy link
Collaborator

@chhluo Please make sure all configurations are enabled or not.

@chhluo
Copy link
Collaborator Author

chhluo commented Jul 25, 2022

@hhaAndroid All config files are added with auto_scale_lr which is disabled.

@chhluo chhluo added the v-2.x label Jul 28, 2022
@ZwwWayne ZwwWayne added this to the 2.26.0 milestone Aug 15, 2022
@ZwwWayne ZwwWayne modified the milestones: 2.26.0, 2.27.0 Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants