-
Notifications
You must be signed in to change notification settings - Fork 9.6k
fix: transpose scale_factors to match the shape of [batch_size, 4] #8757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
Hi @Raysilience Thanks for your kind PR. It seems that CLA is not signed. Could you sign the CLA so that eventually we could merge this PR after review? You can check the contents and follow the instruction in the communication box shown as below |
Hi @ZwwWayne , |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #8757 +/- ##
==========================================
- Coverage 64.08% 64.00% -0.09%
==========================================
Files 361 361
Lines 29525 29525
Branches 5020 4918 -102
==========================================
- Hits 18922 18897 -25
- Misses 9589 9611 +22
- Partials 1014 1017 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @Raysilience !We are grateful for your efforts in helping improve this open-source project during your personal time. |
Motivation
When using
mmdet.apis.inference.inference_detector
to infer a batch of images, I ran into the problem at the 258th line of test_mixins.py indicating the shape mismatch betweendet_bboxes
and 'scale_factors. It turns out that a float scale factor will be expanded by 4 at line 241, thus, outputting a vector of shape (4, batch_size). Whereas
det_bboxes` has a shape of [batch_size, 5]Modification
Transpose scale_factors to match the shape of [batch_size, 4]
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist