Skip to content

[Fix]: fix checking masks on MMDetWandbHook (open-mmlab#8455) #9394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

nanpuhaha
Copy link

@nanpuhaha nanpuhaha commented Nov 27, 2022

Motivation

To fix errors described on #8455.

Exception: input type is not supported.

Modification

Before checking masks is not None, if masks is the list of None, then change to None.

masks = [None, None, ..., None]
masks = None if set(masks) == {None} else masks
masks = None if set(masks) == {None} else masks     # 👈 new lines
if masks is not None:
    wandb_masks = self._get_wandb_masks(
        masks,
        labels,
        is_poly_mask=True,
        height=img_height,
        width=img_width)
else:
    wandb_masks = None

@CLAassistant
Copy link

CLAassistant commented Nov 27, 2022

CLA assistant check
All committers have signed the CLA.

@ZwwWayne ZwwWayne requested a review from hhaAndroid November 27, 2022 11:31
@ZwwWayne ZwwWayne added this to the 3.0.0rc5 milestone Nov 27, 2022
@ZwwWayne ZwwWayne changed the base branch from master to dev November 27, 2022 11:31
@ZwwWayne ZwwWayne modified the milestones: 3.0.0rc5, 2.27.0 Nov 27, 2022
@Cxuery
Copy link

Cxuery commented Mar 30, 2023

Which code file should I modify, in which line?

@OpenMMLab-Assistant001
Copy link

Hi @nanpuhaha !We are grateful for your efforts in helping improve this open-source project during your personal time.

Welcome to join OpenMMLab Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA
If you have a WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)

Thank you again for your contribution❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants