-
Notifications
You must be signed in to change notification settings - Fork 897
Fix exploding idle ctxs array #13061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hello! The Git Commit Checker CI bot found a few problems with this PR: 24c764b: fix exploding idle ctxs array
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
24c764b
to
6917230
Compare
Hello! The Git Commit Checker CI bot found a few problems with this PR: 6917230: fix exploding idle ctxs array Signed-off-by: John ...
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
1 similar comment
Hello! The Git Commit Checker CI bot found a few problems with this PR: 6917230: fix exploding idle ctxs array Signed-off-by: John ...
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
Signed-off-by: zhongyuan chen <[email protected]>
4da56c6
to
c2431d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me but maybe someone more familiar with the oshmem component should take a look (@janjust)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand how this fixes the issue as you replace a bitwise and (so any bits could match) with a strict matching equality. The &
would trigger in all the cases where ==
is true, and more.
I reread the discussion in #13060 and I now think this is a correct patch but not for the reason claimed in the PR log, but because it ensures a strict matching on the context options. Additionally it also covers the case of selecting contexts with no options, which is a plus. I suggest you change the log to make this clear.
Fixes #13060