external data pack: switch to using size_t #13158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bosilca
requested changes
Mar 19, 2025
There was a problem hiding this comment.
Why changing the MPI_Aint to size_t ? The MPI_Aint is coming from the MPI API and is used to also return the size of the packed buffer.
What this PR does is correct internally but incorrect with the interactions of the external entities using thie mechanism (the MPI API and libnbc)
hppritcha
force-pushed
the
fix_for_13152
branch
from
4d32301 to
a105d65
Compare
for count args. This helps with the big count effort. Related to open-mpi#12226 Related to open-mpi#13152 Signed-off-by: Howard Pritchard <[email protected]>
hppritcha
force-pushed
the
fix_for_13152
branch
from
a105d65 to
2fef284
Compare
|
okay i removed the MPI_Aint to size_t. the other change is correct as c handles the integer promotion. ironically libnbc was using size_t already for the count args to these functions. |
devreal
approved these changes
Mar 19, 2025
bosilca
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for count args.
This helps with the big count effort.
Related to #12226
Related to #13152