Skip to content

v5.0.x: configury: fix support for flang on OSX #13162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2025
Merged

v5.0.x: configury: fix support for flang on OSX #13162

merged 1 commit into from
Mar 31, 2025

Conversation

ggouaillardet
Copy link
Contributor

Refs. #13137

  • replace -framework foo with -Wl,-framework,foo
  • replace -dynamiclib with --shared when flang is used
  • use -Wl when needed

Signed-off-by: Gilles Gouaillardet [email protected]
(back-ported from commit fb3e4c2)

@ggouaillardet ggouaillardet requested a review from jsquyres March 25, 2025 03:56
@github-actions github-actions bot added this to the v5.0.8 milestone Mar 25, 2025
@github-actions GitHub Actions
Copy link

Hello! The Git Commit Checker CI bot found a few problems with this PR:

f9a291b: configury: fix support for flang on OSX

  • check_cherry_pick: does not include a cherry pick message (did you need to bot:notacherrypick?)

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

@ggouaillardet ggouaillardet force-pushed the topic/v5.0.x/flang_darwin branch from f9a291b to 19f961a Compare March 25, 2025 04:03
@github-actions GitHub Actions
Copy link

Hello! The Git Commit Checker CI bot found a few problems with this PR:

19f961a: configury: fix support for flang on OSX

  • check_cherry_pick: does not include a cherry pick message (did you need to bot:notacherrypick?)

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

@ggouaillardet
configury: fix support for flang on OSX
b633b4e 
Refs. open-mpi#13137

- replace -framework foo with -Wl,-framework,foo
- replace -dynamiclib with --shared when flang is used
- use -Wl when needed

Signed-off-by: Gilles Gouaillardet <[email protected]>
(cherry picked from commit fb3e4c2)
@ggouaillardet ggouaillardet force-pushed the topic/v5.0.x/flang_darwin branch from 19f961a to b633b4e Compare March 25, 2025 04:05
@ggouaillardet
Copy link
Contributor Author

This commit is a backport (config/ltmain_flang_darwin.diff had to be adapted).
The bot only accepts cherry picked from commit ... or bot:notacherryp....
I might have raised this before, but could we allow something like
back-ported from commit ...
that performs the same checks (if any) as cherry picked from commit ...
?

@ggouaillardet ggouaillardet marked this pull request as ready for review March 25, 2025 05:22
@jsquyres
Copy link
Member

@ggouaillardet Sure. Want to make a PR against https://github.com/open-mpi/pr-git-commit-checker/blob/main/git-commit-checks.py?

@jsquyres jsquyres changed the title configury: fix support for flang on OSX v5.0.x: configury: fix support for flang on OSX Mar 25, 2025
@janjust janjust merged commit 7d8c2e1 into open-mpi:v5.0.x Mar 31, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsquyres jsquyres jsquyres approved these changes

Assignees
No one assigned
Labels
enhancement Target: v5.0.x
Projects
None yet
Milestone
v5.0.8
Development

Successfully merging this pull request may close these issues.
3 participants
@ggouaillardet @jsquyres @janjust