memchecker: fix some problems with arg checking #13174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code which is conditionally compiled when Open MPI is configured with the --enable-memchecker had some bugs. In particular the ompi_datatype_type_extent function was being invoked for some rooted collectives for ranks where the datatype being checked doesn't have to be defined. Also in certain cases the wrong datatype (send,recv) was not being correctly checked. These problems only show up when using the --enable-memchecker config option. Signed-off-by: Howard Pritchard <[email protected]>
bosilca
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code which is conditionally compiled when Open MPI is configured with the --enable-memchecker had some bugs. In particular the ompi_datatype_type_extent function was being invoked for some rooted collectives for ranks where the datatype being checked doesn't have to be defined. Also in certain cases the wrong datatype (send,recv) was not being correctly checked.
These problems only show up when using the --enable-memchecker config option.