coll/ucc: refactor UCC collective operations to handle MPI_IN_PLACE correctly #13224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: a650419: coll/ucc: fix bigcount support
42c7353: coll/ucc: refactor UCC collective operations to ha...
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
…orrectly Updated the initialization functions for allgather, allgatherv, alltoall, alltoallv, gather, gatherv, scatter, and scatterv to improve handling of the MPI_IN_PLACE argument. In case of MPI_IN_PLACE for these collectives corresponding datatype and count should be ignored. Signed-off-by: Sergey Lebedev <[email protected]>
fixing support of bigcount in UCC coll component, coll flags were not set correctly Signed-off-by: Sergey Lebedev <[email protected]>
Sergei-Lebedev
force-pushed
the
topic/fix_ucc_inplace
branch
from
a650419 to
887e7af
Compare
janjust
approved these changes
May 2, 2025
|
@Sergei-Lebedev please cherry pick to v5.0.x |
This was referenced May 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two bugs in coll/ucc component: