mca/op: always define aarch64 macros #13246
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build system changes:
- configure.m4: remove check for Neon floating point support as it is never used
- configure.m4: always define macros to either 0 or 1
- Makefile.am: always declare GENERATE_NEON_CODE and GENERATE_SVE_CODE
Source code (only preprocessor):
- updated macro check to #if instead of #ifdef
- Add compile-time guard in op_aarch64_functions.c to ensure exactly one of GENERATE_SVE_CODE or GENERATE_NEON_CODE is enabled
- added comment above compile-time guard
No changes to the source code logic. Only the build system and macro checks have been changed.
Signed-off-by: Marco Vogel <[email protected]>
jsquyres
approved these changes
May 10, 2025
| @@ -43,12 +43,12 @@ specialized_op_libs = | |||
| if MCA_BUILD_ompi_op_has_neon_support | |||
| specialized_op_libs += liblocal_ops_neon.la | |||
| liblocal_ops_neon_la_SOURCES = op_aarch64_functions.c | |||
| liblocal_ops_neon_la_CPPFLAGS = -DGENERATE_NEON_CODE | |||
| liblocal_ops_neon_la_CPPFLAGS = -DGENERATE_NEON_CODE=1 -DGENERATE_SVE_CODE=0 | |||
There was a problem hiding this comment.
I know this isn't the point of this PR, but is there a difference between these macros and OMPI_MCA_OP_HAVE_NEON and OMPI_MCA_OP_HAVE_SVE?
There was a problem hiding this comment.
I was wondering the same thing. As I understand it, if SVE and NEON support is detected during configuration, the file op_aarch64_functions.c is compiled twice (once with NEON intrinsics and once with SVE intrinsics) producing two libraries. So if both OMPI_MCA_OP_HAVE_NEON and OMPI_MCA_OP_HAVE_SVE are defined, we rely on the GENERATE_NEON_CODE and GENERATE_SVE_CODE macros to ensure that each library build emits only its respective feature implementations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the aarch64 op component’s build configuration to ensure macros are consistently defined in compliance with the style guide.
There are no code logic changes. All changes in the source code files are preprocessor only.
Build system changes:
- configure.m4: remove check for Neon floating point support as it is never used
- configure.m4: always define macros to either 0 or 1
- Makefile.am: always declare GENERATE_NEON_CODE and GENERATE_SVE_CODE
Source code (only preprocessor):
- updated macro check to #if instead of #ifdef
- Add compile-time guard in op_aarch64_functions.c to ensure exactly one of GENERATE_SVE_CODE or GENERATE_NEON_CODE is enabled
- added comment above compile-time guard
This is a follow-up PR of #13204