v5.0.x - OSHMEM/MCA/SPML/UCX: implement put_signal and put_signal_nbi #13631
+62
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 26fa31a) Signed-off-by: Roie Danino <[email protected]>
roiedanino
changed the title
Contributor
Author
|
CI Fails due to #13623 |
devreal
requested changes
Jan 12, 2026
| uint64_t dummy_prev, dummy_fetch; | ||
|
|
||
| if (sig_op == SHMEM_SIGNAL_SET) { | ||
| return MCA_ATOMIC_CALL(swap_nb(ctx, &dummy_fetch, (void*)sig_addr, (void*)&dummy_prev, |
Contributor
There was a problem hiding this comment.
This is unsafe. swap_nb is nonblocking (I assume) and dummy_fetch/dummy_prev will go out of scope before it completes. There is a good chance the network will randomly overwrite stack values. A dedicated heap memory location for dummy values like this is needed.
Contributor
Author
There was a problem hiding this comment.
Good point, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 26fa31a)