Skip to content

Commit 714f133

Browse files
committed
Update manylinux version
1 parent ee9ea5e commit 714f133

1 file changed

Lines changed: 7 additions & 2 deletions

File tree

bindings/pyproject.toml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,17 @@ minimum-version = "build-system.requires"
2626
build-dir = "build/{wheel_tag}"
2727

2828
# ---------------------------------------------------------------------------
29-
# cibuildwheel — produces manylinux_2_28 wheels for PyPI
29+
# cibuildwheel — produces manylinux_2_34 wheels for PyPI
3030
#
3131
# Only one Python version is built because the extension uses nanobind's
3232
# STABLE_ABI + NB_STATIC flags, which produce a cp310-abi3 wheel that is
3333
# compatible with Python 3.10 and all later versions.
3434
#
35+
# manylinux_2_34 (AlmaLinux 9, glibc 2.34) is required because the
36+
# conda-forge packages (pinocchio etc.) introduce symbols newer than
37+
# manylinux_2_28 can guarantee. glibc 2.34 = Ubuntu 22.04+, which is a
38+
# reasonable minimum for a C++20 + Pinocchio 3.9 project.
39+
#
3540
# The before-all script:
3641
# 1. Installs micromamba and creates a conda-forge environment with the
3742
# C++ build tools and runtime libraries (eigen, pinocchio, yaml-cpp …).
@@ -45,7 +50,7 @@ build-dir = "build/{wheel_tag}"
4550
# ---------------------------------------------------------------------------
4651
[tool.cibuildwheel]
4752
build = ["cp310-manylinux_x86_64"]
48-
manylinux-x86_64-image = "manylinux_2_28"
53+
manylinux-x86_64-image = "quay.io/pypa/manylinux_2_34_x86_64"
4954
before-all = "bash {project}/.github/scripts/build_roboplan_deps.sh {project}"
5055

5156
[tool.cibuildwheel.environment]

0 commit comments

Comments
 (0)