Fix SimpleIk return logic on timeout#261
Merged
Merged
Conversation
sea-bass
changed the title
eholum
approved these changes
Jul 13, 2026
eholum
left a comment
eholum
left a comment
Collaborator
There was a problem hiding this comment.
ooooo d'oh, nice catch...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was testing out the ROS interactive marker example and found that a lot of my IK calls as I dragged the marker around were failing!
Turns out there was a bug in the logic when the timeout is hit... and it so happened that
fast_return = Falsewas being used in those demos.For funsies, test the RoboPlan ROS example with and without this change