Align start waypoint with lane exit waypoint for consistency #127
+16
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix
Fixed bug
This PR is not a bug fix but a preventive measure to ensure the planner always starts with a consistent lane-waypoint combination (start's waypoint = lane's exit waypoint).
Related context: Grey’s comment
Fix applied
The validation is applied upstream within
SearchNodePtr make_start_node(), which constructs the planner’s initial search node. If a start condition specifies both a lane and waypoint that are inconsistent, the function automatically corrects the start’s waypoint to match the exit waypoint of the specified lane.This guarantees that all downstream planner logic (e.g., the start will be passed down & used in other functions like
make_start_approach_trajectories()or used to construct the current & nextSearchNode) operates on a consistent and valid start configuration.GenAI Use
We follow OSRA's policy on GenAI tools