Migrate to newer yaserde and Add support for experimental params #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
…_yaserde Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
arjo129
approved these changes
Jul 3, 2025
Member
arjo129
left a comment
arjo129
left a comment
There was a problem hiding this comment.
Thanks for doing this! I wonder how hard it'd be to convince upstream ya-serde maintainers to fix their re-export. Then again it does seem theyre somewhat overwhelmed.
Member
Author
|
There is an upstream issue that I also commented about 2y ago but it's not really making progress, I guess if it was a PR it would be faster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature implementation
Implemented feature
This PR adds support for experimental parameter passing. In the process I had to update
yaserdeotherwise it failed parsing fields that had:in their name.Implementation description
In the process, yaserde dropped the behind the scenes behavior of using
Defaultfor fields that are not found. This is both great because we won't have silently default values but is also not great because a lot of models out there don't actually follow the specification and don't have all the required fields.As a temporary workaround I changed the specification to set some fields that the models in the RMF ecosystem don't set as not required, this is not great but at least unblocks us moving forward while there is a larger discussion on the meaning of "required" in the specification
GenAI Use
We follow OSRA's policy on GenAI tools