Skip to content

Conversation

@db7
Copy link
Member

@db7 db7 commented Nov 25, 2025

No description provided.

@db7 db7 self-assigned this Nov 25, 2025
@radumcostache
Copy link
Collaborator

Checking it right now

@JonasOberhauser
Copy link
Collaborator

I haven't tried to run the shell snippets, but otherwise it looks good to me.
Is this expected to work with a large array of cmake and ctest versions? Otherwise maybe add a (tested with blah blah version blah...) text?

@radumcostache
Copy link
Collaborator

radumcostache commented Nov 25, 2025

I haven't tried to run the shell snippets, but otherwise it looks good to me.

Is this expected to work with a large array of cmake and ctest versions? Otherwise maybe add a (tested with blah blah version blah...) text?

I believe that the features of cmake/ctest that we are using are basic enough so that the version probably wouldn't matter. However, the versions of the following are crucial:

  • Boogie: only the latest release as of today (3.5.5) can handle irreducible control flow (our contribution)
  • Z3: there were huge differences with older versions, not sure how newer ones behave (when compared to the one pinned in the Dockerfile)
  • The cross compilers: initially we were using an older version of Ubuntu, and whatever version apt was installing for that, @lilith218 and I did not manage to inline the asm code for the builtins with that.

@db7
Copy link
Member Author

db7 commented Nov 26, 2025

  • Boogie: only the latest release as of today (3.5.5) can handle irreducible control flow (our contribution)

can you point me to the PR/issue ? I will create a link from the documentation to it

@db7 db7 force-pushed the doc-update branch 4 times, most recently from d3a8f62 to 8a7b16c Compare November 26, 2025 15:50
@radumcostache
Copy link
Collaborator

  • Boogie: only the latest release as of today (3.5.5) can handle irreducible control flow (our contribution)

can you point me to the PR/issue ? I will create a link from the documentation to it

This is the PR: boogie-org/boogie#1032
And this is the Release: https://github.com/boogie-org/boogie/releases/tag/v3.5.5 (don't ask me what is going on with that description :) )

@petemud
Copy link
Collaborator

petemud commented Nov 27, 2025

don't ask me what is going on with that description :)

So... What's going on with that description? :D
Why doesn't it mention (arguably) the most important change?

@db7
Copy link
Member Author

db7 commented Nov 27, 2025

don't ask me what is going on with that description :)

So... What's going on with that description? :D Why doesn't it mention (arguably) the most important change?

@petemud @radumcostache -- can you explain me what is going on here ? :-)

@db7 db7 force-pushed the doc-update branch 3 times, most recently from 5159323 to e4af62d Compare November 27, 2025 09:55
@db7 db7 mentioned this pull request Nov 27, 2025
@petemud
Copy link
Collaborator

petemud commented Nov 27, 2025

I can't explain you, @db7. I can explain to you.

Changelog of release 3.5.5 of Boogie has a bunch about

BigFloat rounding overflow handling in FromRational

and nothing about irreducible control flow.

@db7
Copy link
Member Author

db7 commented Nov 27, 2025

I can't explain you, @db7. I can explain to you.

Got me.

Changelog of release 3.5.5 of Boogie has a bunch about

BigFloat rounding overflow handling in FromRational

and nothing about irreducible control flow.

I see. That is unfortunate. Anyway, we won't forget :D. I added these links to the VERIFICATION.md. If you have any feedback let me know.

@db7 db7 force-pushed the doc-update branch 2 times, most recently from b1e6691 to 604ca3f Compare November 27, 2025 12:09
@db7 db7 merged commit 18b0963 into open-s4c:main Nov 27, 2025
19 checks passed
@db7 db7 deleted the doc-update branch November 28, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants