Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add mbadrawy1 as a contributor #636

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

mbadrawy1
Copy link
Contributor

Description

This PR adds mbadrawy1 as a contributor.

What type of PR is this? (check all applicable)

  • [βœ” ] 🀝 Add a contributor
  • πŸ“ Documentation Update

Related Issues

Closes #635

Contributors Checklist

I've read through the Getting Started section

  • [ βœ”] βœ… Yes
  • ❌ Not yet

Have you run npm run contributors:generate to generate your profile and the badge on the README?

  • [ βœ”] βœ… Yes
  • ❌ No

Added to documentation?

  • [βœ” ] πŸ“œ README.md
  • πŸ™… no documentation needed

Screenshot (Required for PR Review)

image

[optional] What GIF best describes this PR or how it makes you feel?

@mbadrawy1 mbadrawy1 requested a review from a team as a code owner January 17, 2025 18:11
Copy link

Congratulations on completing the How to Contribute to Open Source chapter of the Intro to Open Source Course with your contribution to this repository, @mbadrawy1! You're almost to the end of the course. Create a highlight of your contribution to our guestbook using the instructions in the next chapter and share it with us!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@mbadrawy1
Copy link
Contributor Author

Subject: Follow-Up on Pull Request Review

Hello,
I hope you're doing well! I just wanted to follow up on my pull request #636 and see if there's anything else I need to address to assist with the review process.

I'm happy to make any changes or provide clarification if needed. Thank you for your time and support!

Best regards,
@mbadrawy1

Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mbadrawy1,

Thank you for your contribution. ✨
Everything looks good!

However, we have merged a PR before yours. Please resolve the conflicts before we can review your PR.

Please let me know if you have questions or need any help. Thanks. 😊

@mbadrawy1
Copy link
Contributor Author

Hello @adiati98,
I can't find any conflicts in my VS code workspace.
Below is a screenshot attached
image
Thanks in advance.

@adiati98
Copy link
Member

Hey @mbadrawy1

You first need to update your main branch on GitHub, then your working branch.

Please see these instructions.

Let me know if you have any questions. 😊

@mbadrawy1
Copy link
Contributor Author

Hello @adiati98,
I have done all the required steps and the last one was git push
Should I do anything further?
Thanks.

Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done and thank you for your contribution, @mbadrawy1! ✨

You can check out our pizza-verse repo if you want to contribute further! πŸ•πŸ΄

git merge GIF

@adiati98 adiati98 merged commit 52b8316 into open-sauced:main Jan 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add@mbadrawy1 as a contributor
2 participants