Skip to content

feat: add confirmation dialog before clearing snapshots - #363

Open
Agboolafeyikemi wants to merge 9 commits into
open-source-labs:masterfrom
Agboolafeyikemi:feature/confirm-clear-snapshots
Open

feat: add confirmation dialog before clearing snapshots#363
Agboolafeyikemi wants to merge 9 commits into
open-source-labs:masterfrom
Agboolafeyikemi:feature/confirm-clear-snapshots

Conversation

@Agboolafeyikemi

Copy link
Copy Markdown
Contributor

🔗 Linked issue

Description

Checklist

  • [x ] I've followed the Contributing guidelines

  • [x ] I've titled my PR according to the Conventional Commits spec

  • I've linked an open issue

  • I've added tests that fail without this PR but pass with it

  • [x ] I've linted and tested my code

  • [ x] I've updated documentation (if appropriate)

@vercel

vercel Bot commented Apr 24, 2026

Copy link
Copy Markdown

@Agboolafeyikemi is attempting to deploy a commit to the Reactime Team on Vercel.

A member of the Team first needs to authorize it.

@marsbird
marsbird self-requested a review July 24, 2026 21:57

@marsbird marsbird left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! If you can resolve the conflicts between this and the other most recent PR that was just merged, I'll be able to merge this one as well. Thanks!

Resolve ActionContainer.tsx conflict by combining the Clear confirmation
dialog with master's toast feedback. Extract clearSnapshotsWithFeedback()
so both the direct-clear path and the dialog's confirm button dispatch the
clears and surface the toast.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants