Skip to content

Fix edge placement across multiple instances#550

Open
KingParmenides wants to merge 1 commit into
open-source-labs:mainfrom
KingParmenides:edge-container-instance-fix
Open

Fix edge placement across multiple instances#550
KingParmenides wants to merge 1 commit into
open-source-labs:mainfrom
KingParmenides:edge-container-instance-fix

Conversation

@KingParmenides

Copy link
Copy Markdown

Fixes #513

Summary

  • Use the edge SVG's nearest .svelvet-graph-wrapper when moving it above nodes instead of querying the first wrapper in the document.
  • Add a /multiple-instances repro route with two independent Svelvet instances.
  • Add a focused Playwright regression that connects one edge in each instance and asserts each graph wrapper owns one edge SVG.

Verification

  • npx prettier --plugin-search-dir . --write src/lib/components/Edge/Edge.svelte src/routes/multiple-instances/+page.svelte tests/e2e-tests/multiple-instances/test.ts
  • npm run build
  • git diff --check
  • PLAYWRIGHT_BROWSERS_PATH=0 ./node_modules/.bin/playwright install chromium
  • PLAYWRIGHT_BROWSERS_PATH=0 ./node_modules/.bin/playwright test tests/e2e-tests/multiple-instances/test.ts could not complete in this Codex macOS sandbox because Chromium exits with SIGABRT immediately after launch, before the test body runs.
  • npm run check still fails on existing repo-wide Svelte/TypeScript errors unrelated to this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edges appending to only one instance of Svelvet container

1 participant