Skip to content

fix: scope edge movement to current graph #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
caydyan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: scope edge movement to current graph #551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/lib/components/Edge/Edge.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,17 @@

let animationFrameId: number;

function moveEdge(edgeElement: SVGElement) {
export function moveEdge(edgeElement: SVGElement) {
const newContainer = edgeElement.closest('.svelvet-graph-wrapper');
if (!newContainer) return;

const parentNode = edgeElement.parentNode;
if (!parentNode) return;
// Remove the anchor from its current container
parentNode.removeChild(edgeElement);

// Add the anchor to the new container
const newContainer = document.querySelector(`.svelvet-graph-wrapper`);
if (!newContainer) return;
if (parentNode !== newContainer) {
parentNode.removeChild(edgeElement);
}

newContainer.appendChild(edgeElement);
}
</script>
Expand Down
26 changes: 26 additions & 0 deletions tests/unit-tests/components/edgeMove.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
import { describe, expect, test } from 'vitest';
import { moveEdge } from '../../../src/lib/components/Edge/Edge.svelte';

describe('moveEdge', () => {
test('moves an edge into its nearest Svelvet graph wrapper', () => {
document.body.innerHTML = `
<div class="svelvet-graph-wrapper" data-testid="first">
<svg class="edges-wrapper" data-testid="first-edge"></svg>
</div>
<div class="svelvet-graph-wrapper" data-testid="second">
<svg class="edge-parent">
<svg class="edges-wrapper" data-testid="second-edge"></svg>
</svg>
</div>
`;

const secondWrapper = document.querySelector('[data-testid="second"]');
const secondEdge = document.querySelector('[data-testid="second-edge"]') as SVGElement;

moveEdge(secondEdge);

expect(secondEdge.parentElement).toBe(secondWrapper);
expect(document.querySelectorAll('[data-testid="first"] > .edges-wrapper')).toHaveLength(1);
expect(document.querySelectorAll('[data-testid="second"] > .edges-wrapper')).toHaveLength(1);
});
});