FSRS-7 ADR Support#412
Conversation
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…se, added penalty flag
…FSRS7 penalty/training integration and fractional-interval plumbing, while preserving legacy FSRS6 compatibility semantics.
… longer will be rounded anyway in anki
This reverts commit a334c8a.
There was a problem hiding this comment.
Code Review
This pull request introduces FSRS-7 model support alongside FSRS-6, splitting model-specific math, inference, parameter clipping, and training logic into version-specific modules. It changes the representation of elapsed time (delta_t) from u32 to f32 to support fractional days and same-day reviews. Additionally, it introduces the Cost ADR (Active Desired Retention) policy framework for optimizing desired retention based on study time and memorization targets, complete with simulation paths, training configs, and examples. The review feedback correctly points out a portability issue in a new example file where a specific user's absolute path is hardcoded as the default collection path.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| const DEFAULT_COLLECTION: &str = | ||
| "/Users/jschoreels/Library/Application Support/Anki2/Main Profile/collection.anki2"; |
There was a problem hiding this comment.
Hardcoding an absolute path to a specific user's home directory (/Users/jschoreels/...) breaks portability and will cause the example to fail on other machines unless --collection is explicitly provided. Consider using a relative path to a standard test fixture (like tests/data/collection.anki21) as the default.
const DEFAULT_COLLECTION: &str = "tests/data/collection.anki21";
Hello, this is based on #395 and #404 .
Ofc #395 is a dependency but at least if some people want to try it out, they can also here.
CleanShot.2026-06-02.at.14.30.58.mp4