Skip to content

Expt/add different weights to same-day and non-same-day reviews#271

Draft
L-M-Sherlock wants to merge 2 commits intomainfrom
Expt/add-different-weights-to-same-day-and-non-same-day-reviews
Draft

Expt/add different weights to same-day and non-same-day reviews#271
L-M-Sherlock wants to merge 2 commits intomainfrom
Expt/add-different-weights-to-same-day-and-non-same-day-reviews

Conversation

@L-M-Sherlock
Copy link
Member

No description provided.

@Expertium
Copy link
Contributor

Thank you. Though, after doing some more tests, it now seems that FSRS-7 is worse tthan FSRS-6 at non-same-day reviews regardless

Model: FSRS-7-secs-recency-equalize_test_with_non_secs
Total number of users: 1000
Total number of reviews: 32668830
Weighted average by users:
FSRS-7-secs-recency-equalize_test_with_non_secs LogLoss (mean±std): 0.3609±0.1708
FSRS-7-secs-recency-equalize_test_with_non_secs RMSE(bins) (mean±std): 0.0718±0.0455

Model: FSRS-7-recency
Total number of users: 1000
Total number of reviews: 32668830
Weighted average by users:
FSRS-7-recency LogLoss (mean±std): 0.3603±0.1681
FSRS-7-recency RMSE(bins) (mean±std): 0.0693±0.0432

Model: FSRS-6-secs-recency-equalize_test_with_non_secs
Total number of users: 1000
Total number of reviews: 32668830
Weighted average by users:
FSRS-6-secs-recency-equalize_test_with_non_secs LogLoss (mean±std): 0.3790±0.1803
FSRS-6-secs-recency-equalize_test_with_non_secs RMSE(bins) (mean±std): 0.0907±0.0555

Model: FSRS-6-recency
Total number of users: 1000
Total number of reviews: 32668830
Weighted average by users:
FSRS-6-recency LogLoss (mean±std): 0.3555±0.1653
FSRS-6-recency RMSE(bins) (mean±std): 0.0634±0.0405
image

So I probably won't need to weigh same-day reviews and non-same-day reviews differently, and instead I'll look for other ways to improve FSRS-7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants