Open
Conversation
Signed-off-by: Anton Ivanov <anton.ivanov@cambridgegreys.com>
jeff-yin
previously approved these changes
Nov 30, 2018
rakeshdatta
requested changes
Dec 19, 2018
rakeshdatta
left a comment
rakeshdatta
left a comment
There was a problem hiding this comment.
Can you please run './src/unit_test/run_test' from your opx-base-model directory and share the output.
This will make sure that there are no pyang errors in the model.
Signed-off-by: Anton Ivanov <anton.ivanov@cambridgegreys.com>
Fixes a number of pyang complaints regarding lack of decriptions. Signed-off-by: Anton Ivanov <anton.ivanov@cambridgegreys.com>
Author
|
I have updated the pr to address pyang issues.
…On 19 December 2018 23:25:41 EET, Rakesh Datta ***@***.***> wrote:
rakeshdatta requested changes on this pull request.
Can you please run './src/unit_test/run_test' from your opx-base-model
directory and share the output.
This will make sure that there are no pyang errors in the model.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#43 (review)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
Member
|
@rakeshdatta please update your review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anton Ivanov anton.ivanov@cambridgegreys.com