Skip to content

Remove deprecated warnings_as_errors compile opt for OpentelemetryPhoenix #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danschultzer
Copy link
Collaborator

@danschultzer danschultzer commented Apr 2, 2025

Port from open-telemetry/opentelemetry-erlang-contrib#447


The CI already runs mix compile --warnings-as-errors so it's not necessary to set this option. It'll remove this warning when running the test:

warning: :warnings_as_errors is deprecated as part of Code.put_compiler_option/2, instead you must pass it as a --warnings-as-errors flag. If you need to set it as a default in a mix task, you can also set it under aliases: [compile: "compile --warnings-as-errors"]
  (elixir 1.18.1) lib/code.ex:1710: Code.put_compiler_option/2
  test/test_helper.exs:2: (file)
  (elixir 1.18.1) src/elixir_compiler.erl:77: :elixir_compiler.dispatch/4
  (elixir 1.18.1) src/elixir_compiler.erl:52: :elixir_compiler.compile/4
  (elixir 1.18.1) src/elixir_compiler.erl:39: :elixir_compiler.maybe_fast_compile/2
  (elixir 1.18.1) src/elixir_lexical.erl:13: :elixir_lexical.run/3

@danschultzer danschultzer marked this pull request as ready for review April 2, 2025 11:02
@danschultzer danschultzer force-pushed the main branch 5 times, most recently from 8e44b54 to ed19de1 Compare April 2, 2025 12:00
@danschultzer danschultzer force-pushed the remove-unused-phoenix-test-opt branch from 71bd33a to a4a2ff9 Compare April 2, 2025 12:12
@danschultzer danschultzer force-pushed the main branch 4 times, most recently from 03a97b8 to 4d896a6 Compare April 2, 2025 13:30
@danschultzer danschultzer force-pushed the remove-unused-phoenix-test-opt branch from a4a2ff9 to aaca4cc Compare April 2, 2025 13:36
@danschultzer danschultzer force-pushed the main branch 9 times, most recently from d549221 to b03fe20 Compare April 7, 2025 03:19
@danschultzer danschultzer force-pushed the remove-unused-phoenix-test-opt branch from aaca4cc to 9ee06fe Compare April 7, 2025 03:37
@danschultzer danschultzer force-pushed the remove-unused-phoenix-test-opt branch from 9ee06fe to edbf030 Compare April 7, 2025 06:13
@danschultzer danschultzer force-pushed the main branch 3 times, most recently from a8381b0 to 23ab3da Compare April 7, 2025 18:16
@danschultzer danschultzer force-pushed the remove-unused-phoenix-test-opt branch from edbf030 to 10d6cda Compare April 7, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant