Allow connection settings to be applied asyncronously#544
Open
michel-laterman wants to merge 2 commits intoopen-telemetry:mainfrom
Open
Allow connection settings to be applied asyncronously#544michel-laterman wants to merge 2 commits intoopen-telemetry:mainfrom
michel-laterman wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #544 +/- ##
==========================================
+ Coverage 82.38% 85.10% +2.72%
==========================================
Files 28 28
Lines 2208 2189 -19
==========================================
+ Hits 1819 1863 +44
+ Misses 264 203 -61
+ Partials 125 123 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Expose SetConnectionsSettingsStatus method in client interface to allow implementations that use async approaches to connection management to succeed instead of automatically setting APPLIED.
b4aa108 to
db8b353
Compare
Contributor
Author
|
@tigrannajaryan @evan-bradley, I'm addressing the changes needed in opamp-go for open-telemetry/opentelemetry-collector-contrib#46157 This is a pretty fundamental change as it changes what sets the status from an internal detail (that assumes the callback is synchronous), to something that the connection settings callbacks needs to explicitly set |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose SetConnectionsSettingsStatus method in client interface to allow implementations that use async approaches to connection management to succeed instead of automatically setting APPLIED.
This change technically breaks an assumption we had in the initial implementation and passes the responsibility for setting the connectionsettingsstatus to the callback implementation.
The
client/internal/receivedprocessor.gostill sets the status to APPLYING if any connection settings are sent (and the reports connections settings status capability is set),